all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#29602] [PATCH] gnu: keepassxc: Always install libraries to /lib.
@ 2017-12-07  8:27 Rutger Helling
  2017-12-08  9:48 ` bug#29602: " Ludovic Courtès
  0 siblings, 1 reply; 3+ messages in thread
From: Rutger Helling @ 2017-12-07  8:27 UTC (permalink / raw)
  To: 29602


[-- Attachment #1.1: Type: text/plain, Size: 109 bytes --]

Here's a patch that makes sure keepassxc installs its libraries in /lib
(instead of /lib64 as in some cases).

[-- Attachment #1.2: Type: text/html, Size: 296 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-keepassxc-Always-install-libraries-to-lib.patch --]
[-- Type: text/x-diff; name=0001-gnu-keepassxc-Always-install-libraries-to-lib.patch, Size: 1341 bytes --]

From fdfc9dec4761d4868ee20be2efa5cb6175eb745a Mon Sep 17 00:00:00 2001
From: Rutger Helling <rhelling@mykolab.com>
Date: Thu, 7 Dec 2017 09:21:22 +0100
Subject: [PATCH] gnu: keepassxc: Always install libraries to /lib.

* gnu/packages/password-utils.scm (keepassxc)[arguments]: Add #:configure-flags
argument to force installing libraries to /lib.
---
 gnu/packages/password-utils.scm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
index 64168cc9d..ffa152f27 100644
--- a/gnu/packages/password-utils.scm
+++ b/gnu/packages/password-utils.scm
@@ -14,6 +14,7 @@
 ;;; Copyright © 2017 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2017 Nicolas Goaziou <mail@nicolasgoaziou.fr>
 ;;; Copyright © 2017 Manolis Fragkiskos Ragkousis <manolis837@gmail.com>
+;;; Copyright © 2017 Rutger Helling <rhelling@mykolab.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -98,6 +99,10 @@ human.")
         (base32
          "0wrl8kxb16wzdgfjj057yv18cfg0b8z8lxp1fl2q8fkdgr7phm9g"))))
     (build-system cmake-build-system)
+    (arguments
+     `(#:configure-flags
+       (list (string-append "-DCMAKE_INSTALL_LIBDIR="
+                            (assoc-ref %outputs "out") "/lib"))))
     (inputs
      `(("libgcrypt" ,libgcrypt)
        ("libxi" ,libxi)
-- 
2.15.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#29602: [PATCH] gnu: keepassxc: Always install libraries to /lib.
  2017-12-07  8:27 [bug#29602] [PATCH] gnu: keepassxc: Always install libraries to /lib Rutger Helling
@ 2017-12-08  9:48 ` Ludovic Courtès
  2017-12-08 10:51   ` [bug#29602] " Rutger Helling
  0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2017-12-08  9:48 UTC (permalink / raw)
  To: Rutger Helling; +Cc: 29602-done

Rutger Helling <rhelling@mykolab.com> skribis:

> From fdfc9dec4761d4868ee20be2efa5cb6175eb745a Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling@mykolab.com>
> Date: Thu, 7 Dec 2017 09:21:22 +0100
> Subject: [PATCH] gnu: keepassxc: Always install libraries to /lib.
>
> * gnu/packages/password-utils.scm (keepassxc)[arguments]: Add #:configure-flags
> argument to force installing libraries to /lib.

Applied, thanks.

> +    (arguments
> +     `(#:configure-flags
> +       (list (string-append "-DCMAKE_INSTALL_LIBDIR="
> +                            (assoc-ref %outputs "out") "/lib"))))

At some point we should probably fix ‘cmake-build-system’.  Thoughts?

Ludo’.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#29602] [PATCH] gnu: keepassxc: Always install libraries to /lib.
  2017-12-08  9:48 ` bug#29602: " Ludovic Courtès
@ 2017-12-08 10:51   ` Rutger Helling
  0 siblings, 0 replies; 3+ messages in thread
From: Rutger Helling @ 2017-12-08 10:51 UTC (permalink / raw)
  To: ludo; +Cc: 29602-done

[-- Attachment #1: Type: text/plain, Size: 844 bytes --]

I agree, it makes more sense to set CMAKE_INSTALL_LIBDIR by default in
'cmake-build-system. 

On 2017-12-08 10:48, ludo@gnu.org wrote:

> Rutger Helling <rhelling@mykolab.com> skribis:
> 
>> From fdfc9dec4761d4868ee20be2efa5cb6175eb745a Mon Sep 17 00:00:00 2001
>> From: Rutger Helling <rhelling@mykolab.com>
>> Date: Thu, 7 Dec 2017 09:21:22 +0100
>> Subject: [PATCH] gnu: keepassxc: Always install libraries to /lib.
>> 
>> * gnu/packages/password-utils.scm (keepassxc)[arguments]: Add #:configure-flags
>> argument to force installing libraries to /lib.
> 
> Applied, thanks.
> 
>> +    (arguments
>> +     `(#:configure-flags
>> +       (list (string-append "-DCMAKE_INSTALL_LIBDIR="
>> +                            (assoc-ref %outputs "out") "/lib"))))
> 
> At some point we should probably fix 'cmake-build-system'.  Thoughts?
> 
> Ludo'.

[-- Attachment #2: Type: text/html, Size: 1867 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-12-08 10:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-07  8:27 [bug#29602] [PATCH] gnu: keepassxc: Always install libraries to /lib Rutger Helling
2017-12-08  9:48 ` bug#29602: " Ludovic Courtès
2017-12-08 10:51   ` [bug#29602] " Rutger Helling

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.