* [bug#32140] [PATCH] gnu: make-u-boot-package: Don't install "sunxi-spl-with-ecc.bin".
@ 2018-07-13 13:57 Danny Milosavljevic
2018-07-17 22:16 ` Ludovic Courtès
0 siblings, 1 reply; 2+ messages in thread
From: Danny Milosavljevic @ 2018-07-13 13:57 UTC (permalink / raw)
To: 32140
* gnu/packages/bootloaders.scm (make-u-boot-package)[arguments]<#:phases>
[install]: Don't install "sunxi-spl-with-ecc.bin".
---
gnu/packages/bootloaders.scm | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
index 7599f4ac2..19d47e6e5 100644
--- a/gnu/packages/bootloaders.scm
+++ b/gnu/packages/bootloaders.scm
@@ -508,7 +508,19 @@ board-independent tools.")))
(let* ((out (assoc-ref outputs "out"))
(libexec (string-append out "/libexec"))
(uboot-files (append
- (find-files "." ".*\\.(bin|efi|img|spl|itb|dtb|rksd)$")
+ (filter
+ ;; Those would not be reproducible
+ ;; because of the randomness used
+ ;; to produce them.
+ ;; It's expected that the user will
+ ;; use u-boot-tools to generate them
+ ;; instead.
+ (lambda (name)
+ (not
+ (string-suffix?
+ "sunxi-spl-with-ecc.bin"
+ name)))
+ (find-files "." ".*\\.(bin|efi|img|spl|itb|dtb|rksd)$"))
(find-files "." "^(MLO|SPL)$"))))
(mkdir-p libexec)
(install-file ".config" libexec)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [bug#32140] [PATCH] gnu: make-u-boot-package: Don't install "sunxi-spl-with-ecc.bin".
2018-07-13 13:57 [bug#32140] [PATCH] gnu: make-u-boot-package: Don't install "sunxi-spl-with-ecc.bin" Danny Milosavljevic
@ 2018-07-17 22:16 ` Ludovic Courtès
0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2018-07-17 22:16 UTC (permalink / raw)
To: Danny Milosavljevic; +Cc: 32140
Hi Danny,
Danny Milosavljevic <dannym@scratchpost.org> skribis:
> * gnu/packages/bootloaders.scm (make-u-boot-package)[arguments]<#:phases>
> [install]: Don't install "sunxi-spl-with-ecc.bin".
> ---
> gnu/packages/bootloaders.scm | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
> index 7599f4ac2..19d47e6e5 100644
> --- a/gnu/packages/bootloaders.scm
> +++ b/gnu/packages/bootloaders.scm
> @@ -508,7 +508,19 @@ board-independent tools.")))
> (let* ((out (assoc-ref outputs "out"))
> (libexec (string-append out "/libexec"))
> (uboot-files (append
> - (find-files "." ".*\\.(bin|efi|img|spl|itb|dtb|rksd)$")
> + (filter
> + ;; Those would not be reproducible
> + ;; because of the randomness used
> + ;; to produce them.
> + ;; It's expected that the user will
> + ;; use u-boot-tools to generate them
> + ;; instead.
> + (lambda (name)
> + (not
> + (string-suffix?
Nitpick: you could write: (remove (lambda (string-suffix? …)) lst)
instead.
Otherwise LGTM, thanks!
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-17 22:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-13 13:57 [bug#32140] [PATCH] gnu: make-u-boot-package: Don't install "sunxi-spl-with-ecc.bin" Danny Milosavljevic
2018-07-17 22:16 ` Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.