From: "Ludovic Courtès" <ludo@gnu.org>
To: Arne Babenhauserheide <arne_bab@web.de>
Cc: 34128@debbugs.gnu.org
Subject: [bug#34128] [PATCH] add emacs built with xwidgets-support
Date: Tue, 22 Jan 2019 22:48:26 +0100 [thread overview]
Message-ID: <87lg3cjrdh.fsf@gnu.org> (raw)
In-Reply-To: <87zhrx4mlu.fsf@web.de> (Arne Babenhauserheide's message of "Fri, 18 Jan 2019 23:29:14 +0100")
Hi Arne,
Arne Babenhauserheide <arne_bab@web.de> skribis:
> * gnu/packages/emacs.scm (emacs-xwidgets): new variable
Thanks for the patch! I wonder why this hadn’t been done before;
Nicolas, Alex, Pierre, thoughts?
The patch LGTM, minor stylistic issues:
> +(define-public emacs-xwidgets
> + (package (inherit emacs)
> + (name "emacs-xwidgets")
> + (synopsis "The extensible, customizable, self-documenting text
> +editor (with xwidgets support)")
> + (build-system gnu-build-system)
> + (arguments (append
> + (package-arguments emacs)
> + `(#:configure-flags
> + '("--with-xwidgets"))))
> + (inputs (append
> + (package-inputs emacs)
> + `(("webkitgtk" ,webkitgtk)
> + ("libxcomposite" ,libxcomposite))))))
Please indent rather along these lines (like in the rest of the file):
(define-public emacs-xwidgets
(package
(inherit emacs)
(name …) …))
Likewise, for consistency, use unquote-splicing rather than ‘append’:
(inputs `(("webkitgtk" ,webkitgtk)
;; …
,@(package-inputs emacs)))
Could you send an updated patch?
Thanks,
Ludo’.
next prev parent reply other threads:[~2019-01-22 21:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 22:29 [bug#34128] [PATCH] add emacs built with xwidgets-support Arne Babenhauserheide
2019-01-22 21:48 ` Ludovic Courtès [this message]
2019-01-22 23:10 ` Arne Babenhauserheide
2019-01-23 8:19 ` Ricardo Wurmus
2019-01-23 9:37 ` Arne Babenhauserheide
2019-01-23 9:53 ` Ludovic Courtès
2019-01-23 11:41 ` Ricardo Wurmus
2019-01-23 22:29 ` bug#34128: " Ludovic Courtès
2019-01-24 19:06 ` [bug#34128] " Arne Babenhauserheide
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg3cjrdh.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=34128@debbugs.gnu.org \
--cc=arne_bab@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.