From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:60533)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gm3ur-0005j5-7y
	for guix-patches@gnu.org; Tue, 22 Jan 2019 16:49:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gm3up-000674-EO
	for guix-patches@gnu.org; Tue, 22 Jan 2019 16:49:05 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:42364)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gm3uo-00066A-Ff
	for guix-patches@gnu.org; Tue, 22 Jan 2019 16:49:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gm3uo-000278-3O
	for guix-patches@gnu.org; Tue, 22 Jan 2019 16:49:02 -0500
Subject: [bug#34128] [PATCH] add emacs built with xwidgets-support
Resent-Message-ID: <handler.34128.B34128.15481937258089@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87zhrx4mlu.fsf@web.de>
Date: Tue, 22 Jan 2019 22:48:26 +0100
In-Reply-To: <87zhrx4mlu.fsf@web.de> (Arne Babenhauserheide's message of "Fri,
	18 Jan 2019 23:29:14 +0100")
Message-ID: <87lg3cjrdh.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Arne Babenhauserheide <arne_bab@web.de>
Cc: 34128@debbugs.gnu.org

Hi Arne,

Arne Babenhauserheide <arne_bab@web.de> skribis:

> * gnu/packages/emacs.scm (emacs-xwidgets): new variable

Thanks for the patch!  I wonder why this hadn=E2=80=99t been done before;
Nicolas, Alex, Pierre, thoughts?

The patch LGTM, minor stylistic issues:

> +(define-public emacs-xwidgets
> +  (package (inherit emacs)
> +           (name "emacs-xwidgets")
> +           (synopsis "The extensible, customizable, self-documenting text
> +editor (with xwidgets support)")
> +           (build-system gnu-build-system)
> +           (arguments (append
> +                       (package-arguments emacs)
> +                       `(#:configure-flags
> +                         '("--with-xwidgets"))))
> +           (inputs (append
> +                    (package-inputs emacs)
> +                    `(("webkitgtk" ,webkitgtk)
> +                      ("libxcomposite" ,libxcomposite))))))

Please indent rather along these lines (like in the rest of the file):

  (define-public emacs-xwidgets
    (package
      (inherit emacs)
      (name =E2=80=A6) =E2=80=A6))

Likewise, for consistency, use unquote-splicing rather than =E2=80=98append=
=E2=80=99:

  (inputs `(("webkitgtk" ,webkitgtk)
            ;; =E2=80=A6
            ,@(package-inputs emacs)))

Could you send an updated patch?

Thanks,
Ludo=E2=80=99.