all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#38848] Fix path substitution in IBus
@ 2020-01-01 10:15 kanichos
  2020-01-01 22:56 ` bug#38848: " Ricardo Wurmus
  0 siblings, 1 reply; 2+ messages in thread
From: kanichos @ 2020-01-01 10:15 UTC (permalink / raw)
  To: 38848

The IBus package has been broken since forever because it substitutes paths to setxkbmap and xmodmap binaries with package directories.

---
gnu/packages/ibus.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/ibus.scm b/gnu/packages/ibus.scm
index 5057927174..42a8d5db32 100644
--- a/gnu/packages/ibus.scm
+++ b/gnu/packages/ibus.scm
@@ -116,7 +116,7 @@
                               "/share/X11/locale")))
             (substitute* "ui/gtk3/xkblayout.vala"
               (("\"(setxkbmap|xmodmap)\"" _ prog)
-                (string-append "\"" (assoc-ref inputs prog) "\"")))
+                (string-append "\"" (assoc-ref inputs prog) "/bin/" prog "\"")))
             #t))
         (add-after 'wrap-program 'wrap-with-additional-paths
           (lambda* (#:key outputs #:allow-other-keys)
--
2.23.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#38848: Fix path substitution in IBus
  2020-01-01 10:15 [bug#38848] Fix path substitution in IBus kanichos
@ 2020-01-01 22:56 ` Ricardo Wurmus
  0 siblings, 0 replies; 2+ messages in thread
From: Ricardo Wurmus @ 2020-01-01 22:56 UTC (permalink / raw)
  To: kanichos; +Cc: 38848-done


kanichos@yandex.ru writes:

> The IBus package has been broken since forever because it substitutes
> paths to setxkbmap and xmodmap binaries with package directories.

Oh, good catch!  Thanks!
(I’ve only ever been using libpinyin, so I never noticed…)

Pushed to the master branch with commit 92d7f5b45d.

--
Ricardo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-01-01 22:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-01 10:15 [bug#38848] Fix path substitution in IBus kanichos
2020-01-01 22:56 ` bug#38848: " Ricardo Wurmus

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.