all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: John Soo <jsoo1@asu.edu>
Cc: Help Guix <help-guix@gnu.org>
Subject: Re: BPF in linux-libre
Date: Sun, 05 Jul 2020 10:18:14 +0200	[thread overview]
Message-ID: <87lfjyjry1.fsf@gnu.org> (raw)
In-Reply-To: <871rlsegf2.fsf@asu.edu> (John Soo's message of "Fri, 03 Jul 2020 09:01:37 -0700")


Hello John,

Thanks for this serie, a few remarks below.

> +(define-public libbpf
> +  (let* ((commit "6a1615c263b679c17ecb292fa897f159e826dc10"))

Why using a specific commit?

> +    (package
> +      (name "libbpf")
> +      (version "0.0.8")

The "0.0.9" is out there :)

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/libbpf/libbpf")
> +               (commit commit)))

(commit (string-append "v" version)) should work fine.

> +         ("pkg-config" ,pkg-config)

This should be a native-input, don't forget to run the linter :)

> +          (string-append "PREFIX=''")
> +          (string-append "DESTDIR=" (assoc-ref %outputs "out"))
> +          (string-append
> +           "CC=" (assoc-ref %build-inputs "gcc") "/bin/gcc"))

This will put libraries in "lib64" directory which is not desired. You
can set LIBDIR to "/lib" to avoid that.

> +               (chdir "src")

I'm not sure this is needed.

> +               #t)))))
> +      (home-page "https://github.com/libbpf/libbpf")
> +      (synopsis "BPF CO-RE (Compile Once – Run Everywhere)")
> +      (description
> +       "Libbpf supports building BPF CO-RE-enabled applications, which, in
> +contrast to BCC, do not require Clang/LLVM runtime being deployed to target
> +servers and does not rely on kernel-devel headers being available.")

"kernel-devel" is more Debian specific I think. I'm also not sure that
the "Clang deploying" things applied well to Guix.

Thanks,

Mathieu


  reply	other threads:[~2020-07-05  8:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-14  3:21 BPF in linux-libre John Soo
2020-06-14  9:23 ` Mathieu Othacehe
2020-06-14 15:11   ` John Soo
2020-06-17 10:16     ` Mathieu Othacehe
2020-06-17 13:42       ` John Soo
2020-06-21 15:32       ` John Soo
2020-06-26 10:50         ` Mathieu Othacehe
2020-06-28 20:24           ` John Soo
2020-07-01  5:40           ` John Soo
2020-07-03 16:01           ` John Soo
2020-07-05  8:18             ` Mathieu Othacehe [this message]
2020-07-05  8:20             ` Mathieu Othacehe
2020-07-06  0:44               ` John Soo
2020-07-06 13:26                 ` [bug#42227] " Mathieu Othacehe
2020-07-11 16:28                   ` John Soo
2020-07-30 18:48                     ` Mathieu Othacehe
2020-07-31  2:20                       ` John Soo
2020-07-31 11:04                         ` bug#42227: " Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfjyjry1.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=help-guix@gnu.org \
    --cc=jsoo1@asu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.