From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id EHuAEtSMAV8pWQAA0tVLHw (envelope-from ) for ; Sun, 05 Jul 2020 08:18:28 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id yAxZDtSMAV9CGwAA1q6Kng (envelope-from ) for ; Sun, 05 Jul 2020 08:18:28 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C5BAB940712 for ; Sun, 5 Jul 2020 08:18:27 +0000 (UTC) Received: from localhost ([::1]:50260 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jrzqz-0005oT-70 for larch@yhetil.org; Sun, 05 Jul 2020 04:18:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jrzqs-0005oG-7F for help-guix@gnu.org; Sun, 05 Jul 2020 04:18:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59007) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jrzqr-0002Wz-Dy; Sun, 05 Jul 2020 04:18:17 -0400 Received: from [2a01:e0a:fa:a50:84fd:6270:81db:82dd] (port=52838 helo=meru) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jrzqp-0004jY-TJ; Sun, 05 Jul 2020 04:18:17 -0400 From: Mathieu Othacehe To: John Soo Subject: Re: BPF in linux-libre References: <44046537-51AD-4BD7-8442-41738C4D8C98@asu.edu> <87lfkqknla.fsf@gnu.org> <87h7vdd6ms.fsf@asu.edu> <87wo46uhdr.fsf@gnu.org> <87zh8wph7h.fsf@asu.edu> <87wo3uxfrq.fsf@gnu.org> <871rlsegf2.fsf@asu.edu> Date: Sun, 05 Jul 2020 10:18:14 +0200 In-Reply-To: <871rlsegf2.fsf@asu.edu> (John Soo's message of "Fri, 03 Jul 2020 09:01:37 -0700") Message-ID: <87lfjyjry1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: help-guix@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Help Guix Errors-To: help-guix-bounces+larch=yhetil.org@gnu.org Sender: "Help-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of help-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=help-guix-bounces@gnu.org X-Spam-Score: 0.49 X-TUID: EMjeE2nSl83K Hello John, Thanks for this serie, a few remarks below. > +(define-public libbpf > + (let* ((commit "6a1615c263b679c17ecb292fa897f159e826dc10")) Why using a specific commit? > + (package > + (name "libbpf") > + (version "0.0.8") The "0.0.9" is out there :) > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/libbpf/libbpf") > + (commit commit))) (commit (string-append "v" version)) should work fine. > + ("pkg-config" ,pkg-config) This should be a native-input, don't forget to run the linter :) > + (string-append "PREFIX=3D''") > + (string-append "DESTDIR=3D" (assoc-ref %outputs "out")) > + (string-append > + "CC=3D" (assoc-ref %build-inputs "gcc") "/bin/gcc")) This will put libraries in "lib64" directory which is not desired. You can set LIBDIR to "/lib" to avoid that. > + (chdir "src") I'm not sure this is needed. > + #t))))) > + (home-page "https://github.com/libbpf/libbpf") > + (synopsis "BPF CO-RE (Compile Once =E2=80=93 Run Everywhere)") > + (description > + "Libbpf supports building BPF CO-RE-enabled applications, which, = in > +contrast to BCC, do not require Clang/LLVM runtime being deployed to tar= get > +servers and does not rely on kernel-devel headers being available.") "kernel-devel" is more Debian specific I think. I'm also not sure that the "Clang deploying" things applied well to Guix. Thanks, Mathieu