* [bug#43338] [PATCH] gnu: Add ripmime.
@ 2020-09-11 13:54 Sébastien Lerique
2020-09-13 21:16 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: Sébastien Lerique @ 2020-09-11 13:54 UTC (permalink / raw)
To: 43338
* gnu/packages/mail.scm (ripmime): New variable.
---
gnu/packages/mail.scm | 44
+++++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 7af7e8a8d7..48e9a11522 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -627,6 +627,50 @@ Extension (MIME).")
(base32
"0slzlzcr3h8jikpz5a5amqd0csqh2m40gdk910ws2hnaf5m6hjbi"))))))
+(define-public ripmime
+ (let ((commit "a556ffe08d620602475c976732e8e1a82f3169e9")
+ (revision "1"))
+ (package
+ (name "ripmime")
+ (version (git-version "1.4.0.10" revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/inflex/ripMIME")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+
"1z8ar8flvkd9q3ax4x28sj5pyq8ykk5pq249y967lj2406lxparh"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ ;; Source has no configure script
+ (delete 'configure)
+ ;; Buildcodes make the build non-reproducible; remove
them
+ (add-after 'unpack 'strip-buildcodes
+ (lambda _
+ (substitute* "generate-buildcodes.sh"
+ (("`date \\+%s`") "0")
+ (("`date`") "0")
+ (("`uname -a`") "Guix"))))
+ ;; https://github.com/inflex/ripMIME/pull/16 makes
`mkdir-p-bin-man unnecessary
+ (add-before 'install 'mkdir-p-bin-man
+ (lambda _
+ (mkdir-p (string-append (assoc-ref %outputs "out")
"/bin"))
+ (mkdir-p (string-append (assoc-ref %outputs "out")
"/man")))))
+ ;; Makefile has no tests
+ #:tests? #f
+ #:make-flags (list (string-append "LOCATION=" (assoc-ref
%outputs "out"))
+ "CC=gcc")))
+ (synopsis "Extract attachments from MIME-encoded email")
+ (description
+ "ripMIME is a small program which is used to extract the
attached files
+out of a MIME-encoded email package.")
+ (home-page "https://github.com/inflex/ripMIME")
+ (license license:bsd-3))))
+
(define-public bogofilter
(package
(name "bogofilter")
--
2.28.0
---
Hello Guix!
This is my first contribution -- please let me know if things
should be adapted!
Cheers,
Sébastien
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#43338] [PATCH] gnu: Add ripmime.
2020-09-11 13:54 [bug#43338] [PATCH] gnu: Add ripmime Sébastien Lerique
@ 2020-09-13 21:16 ` Ludovic Courtès
2020-09-14 8:59 ` Sébastien Lerique
0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2020-09-13 21:16 UTC (permalink / raw)
To: Sébastien Lerique; +Cc: 43338
Hello Sébastien!
Sébastien Lerique <sl@eauchat.org> skribis:
> * gnu/packages/mail.scm (ripmime): New variable.
> ---
> gnu/packages/mail.scm | 44
> +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
Looks like your mail client mangled the patch. Could you send it as an
attachment or using ‘git send-email’? (See <https://git-send-email.io/>
for a tutorial.)
> diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
> index 7af7e8a8d7..48e9a11522 100644
> --- a/gnu/packages/mail.scm
> +++ b/gnu/packages/mail.scm
> @@ -627,6 +627,50 @@ Extension (MIME).")
> (base32
> "0slzlzcr3h8jikpz5a5amqd0csqh2m40gdk910ws2hnaf5m6hjbi"))))))
>
> +(define-public ripmime
> + (let ((commit "a556ffe08d620602475c976732e8e1a82f3169e9")
> + (revision "1"))
> + (package
> + (name "ripmime")
> + (version (git-version "1.4.0.10" revision commit))
In general we provide released versions, unless there’s a good reason to
pick a development snapshot. If it falls in this category, could you
add a short comment above the commit ID explaining why?
> + (add-after 'unpack 'strip-buildcodes
> + (lambda _
> + (substitute* "generate-buildcodes.sh"
> + (("`date \\+%s`") "0")
> + (("`date`") "0")
> + (("`uname -a`") "Guix"))))
Please return #t at the end of the phase (it’s a convention).
> + ;; https://github.com/inflex/ripMIME/pull/16 makes
> `mkdir-p-bin-man unnecessary
> + (add-before 'install 'mkdir-p-bin-man
> + (lambda _
> + (mkdir-p (string-append (assoc-ref %outputs "out")
> "/bin"))
> + (mkdir-p (string-append (assoc-ref %outputs "out")
> "/man")))))
Likewise.
> + (synopsis "Extract attachments from MIME-encoded email")
> + (description
> + "ripMIME is a small program which is used to extract the
> attached files
s/which is used//g
> +out of a MIME-encoded email package.")
Could you send an updated patch?
Thanks for this first contribution! :-)
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [bug#43338] [PATCH] gnu: Add ripmime.
2020-09-13 21:16 ` Ludovic Courtès
@ 2020-09-14 8:59 ` Sébastien Lerique
0 siblings, 0 replies; 3+ messages in thread
From: Sébastien Lerique @ 2020-09-14 8:59 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 43338
Hello,
On 13 Sep 2020 at 23:16, Ludovic Courtès <ludo@gnu.org> wrote:
> Could you send an updated patch?
Thanks for the quick (and newcomer-friendly) feedback! The v2 I
just submitted hopefully fixes all the issues.
> Thanks for this first contribution! :-)
Pretty excited as it's my first packaging experience anywhere.
Sébastien
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-14 17:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-11 13:54 [bug#43338] [PATCH] gnu: Add ripmime Sébastien Lerique
2020-09-13 21:16 ` Ludovic Courtès
2020-09-14 8:59 ` Sébastien Lerique
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.