From: "Miguel Ángel Arruga Vivas" <rosen644835@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 44321@debbugs.gnu.org
Subject: [bug#44321] [PATCH 4/6] guix build: Move transformation options to (guix transformations).
Date: Sat, 31 Oct 2020 00:03:03 +0100 [thread overview]
Message-ID: <87lffn48rc.fsf@gmail.com> (raw)
In-Reply-To: <20201029231000.14568-4-ludo@gnu.org> ("Ludovic Courtès"'s message of "Fri, 30 Oct 2020 00:09:58 +0100")
Hi Ludo,
Ludovic Courtès <ludo@gnu.org> writes:
> * guix/transformations.scm: New file.
The main comment regarding this patch is that file has to be added to
po/guix/POTFILES.in, or the translations will be lost.
I've seen that you've changed some code identifiers, here:
> - (else (tarball-base-name (file-sans-extension file-name)))))
> + (_ (tarball-base-name (file-sans-extension file-name)))))
And there:
> - (x
> + (_
And these changes seem sensible as the match parameter is unused.
Other than the first comment, the patch LGTM.
Happy hacking,
Miguel
next prev parent reply other threads:[~2020-10-30 23:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 23:08 [bug#44321] [PATCH 0/6] Adding a (guix transformations) module Ludovic Courtès
2020-10-29 23:09 ` [bug#44321] [PATCH 1/6] guix build: 'package-with-source' no longer takes a 'store' parameter Ludovic Courtès
2020-10-29 23:09 ` [bug#44321] [PATCH 2/6] guix build: Remove unnecessary (replacement #f) Ludovic Courtès
2020-10-29 23:09 ` [bug#44321] [PATCH 3/6] guix build: 'options->transformation' no longer takes a 'store' parameter Ludovic Courtès
2020-10-30 22:27 ` Miguel Ángel Arruga Vivas
2020-10-31 10:03 ` Ludovic Courtès
2020-10-29 23:09 ` [bug#44321] [PATCH 4/6] guix build: Move transformation options to (guix transformations) Ludovic Courtès
2020-10-30 23:03 ` Miguel Ángel Arruga Vivas [this message]
2020-10-31 10:04 ` Ludovic Courtès
2020-10-29 23:09 ` [bug#44321] [PATCH 5/6] transformations: Raise '&formatted-message' exceptions instead of 'leave' Ludovic Courtès
2020-10-30 10:59 ` zimoun
2020-10-30 22:39 ` Miguel Ángel Arruga Vivas
2020-10-31 10:06 ` Ludovic Courtès
2020-10-31 22:18 ` bug#44321: " Ludovic Courtès
2020-11-02 12:25 ` [bug#44321] " zimoun
2020-11-02 15:48 ` Ludovic Courtès
2020-10-29 23:10 ` [bug#44321] [PATCH 6/6] doc: Add "Defining Package Variants" section Ludovic Courtès
2020-10-30 11:20 ` zimoun
2020-10-31 10:14 ` Ludovic Courtès
2020-10-30 23:27 ` [bug#44321] [PATCH 1/6] guix build: 'package-with-source' no longer takes a 'store' parameter Miguel Ángel Arruga Vivas
2020-10-31 10:17 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lffn48rc.fsf@gmail.com \
--to=rosen644835@gmail.com \
--cc=44321@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.