From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mN/VDOybnF/OIAAA0tVLHw (envelope-from ) for ; Fri, 30 Oct 2020 23:04:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 6KyZCOybnF/6YgAAbx9fmQ (envelope-from ) for ; Fri, 30 Oct 2020 23:04:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B7C9D940366 for ; Fri, 30 Oct 2020 23:04:11 +0000 (UTC) Received: from localhost ([::1]:37114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYdRK-0006i8-8x for larch@yhetil.org; Fri, 30 Oct 2020 19:04:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYdRC-0006ho-H3 for guix-patches@gnu.org; Fri, 30 Oct 2020 19:04:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48578) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYdRC-0002Kg-7V for guix-patches@gnu.org; Fri, 30 Oct 2020 19:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYdRC-0004Rx-2R for guix-patches@gnu.org; Fri, 30 Oct 2020 19:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44321] [PATCH 4/6] guix build: Move transformation options to (guix transformations). Resent-From: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 30 Oct 2020 23:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44321 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 44321@debbugs.gnu.org Received: via spool by 44321-submit@debbugs.gnu.org id=B44321.160409899417047 (code B ref 44321); Fri, 30 Oct 2020 23:04:02 +0000 Received: (at 44321) by debbugs.gnu.org; 30 Oct 2020 23:03:14 +0000 Received: from localhost ([127.0.0.1]:60124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYdQP-0004Qt-T6 for submit@debbugs.gnu.org; Fri, 30 Oct 2020 19:03:14 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:42547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYdQP-0004Qd-21 for 44321@debbugs.gnu.org; Fri, 30 Oct 2020 19:03:13 -0400 Received: by mail-wr1-f46.google.com with SMTP id w14so8091381wrs.9 for <44321@debbugs.gnu.org>; Fri, 30 Oct 2020 16:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=qPlLdm4hgViuCskRiMv/oW9apRoQom/z4pmB20s4i9E=; b=L79Dxb+n1ey9B6NztftlDW1pKaVfXWFta7fNSm6xhMgbn7/VNw/bwVVC3FBX8yUART CVQEqn1gcKjeuQ4e4eufDoSa1D0x2VcU+GdBCaWnRq1vOp4O6ThruehtcP2COIakpR9f owfyaQ2S6YKyc2U0rU/adWxJ4Vyhfdpqcd22uOJttC0DtCYHAmR7LDLR5KO+PptpZa3f BuPurnc7CT0SkGz+dSX4WIcR6qwWg0gq0L4rfgaMxd4hHHwTO54fZwmSUWBZpR+biGWF SwmtGz6hAwJb1E1uyG8Y+ATWkf98J47CJY35KvCDskp4C4MKKGmc0qNHczgN1cKT4fD8 vlTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=qPlLdm4hgViuCskRiMv/oW9apRoQom/z4pmB20s4i9E=; b=traSZBCtq64SOF5NftDN7gW5EXANM2I/3Dni6YkDw/RPDN0Zhp3+e0qUXrxD5YDJ7w VU43UPbw6pQ671Gc50AYNVhhs6SsUohMZMn9t4Ux1xcxJ5MkA2/kulsi7H1JcQC2D438 l7mFQPgij0TL7mvhehOio7vRNWwSqAa1/0ozQmQMPRchKC8tUHYXw4kDpx1CrwWZreYK tR/+BCIFeIsMUjmxcaWZALEBGvLjO7KUXw3NsXngGw+zNnTFoRZPfIdQA+C9hSESZjzn 0sdV4jvX1rXVTrh0+bQYji61kohpdQ5bOI5eKzkdsN4BWo078ZpPKfRKzSUUBtQPhScm VJRg== X-Gm-Message-State: AOAM533SkwYasae3RNYF8yrxBBcuQZZsVyO+kgjkjYjo9slJBDAMTWse 2pOnISpkDn0Ya0EX9OWZo7ZZYQ2Kqvadbw== X-Google-Smtp-Source: ABdhPJw1CVWdge12b0oqQLnYvokmArCyC1mpA4Wxz1mCkP7Y/vaPAnbJYMJH8XOA02ofWSvgRT6pxg== X-Received: by 2002:adf:f4d2:: with SMTP id h18mr5676366wrp.99.1604098987010; Fri, 30 Oct 2020 16:03:07 -0700 (PDT) Received: from unfall (218.139.134.37.dynamic.jazztel.es. [37.134.139.218]) by smtp.gmail.com with ESMTPSA id m8sm12059647wrw.17.2020.10.30.16.03.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Oct 2020 16:03:06 -0700 (PDT) From: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas References: <20201029231000.14568-1-ludo@gnu.org> <20201029231000.14568-4-ludo@gnu.org> Date: Sat, 31 Oct 2020 00:03:03 +0100 In-Reply-To: <20201029231000.14568-4-ludo@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Fri, 30 Oct 2020 00:09:58 +0100") Message-ID: <87lffn48rc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -0.8 (/) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=L79Dxb+n; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: 80UzQDz6+Fyd Hi Ludo, Ludovic Court=C3=A8s writes: > * guix/transformations.scm: New file. The main comment regarding this patch is that file has to be added to po/guix/POTFILES.in, or the translations will be lost. I've seen that you've changed some code identifiers, here: > - (else (tarball-base-name (file-sans-extension file-name))))) > + (_ (tarball-base-name (file-sans-extension file-name))))) And there: > - (x > + (_ And these changes seem sensible as the match parameter is unused. Other than the first comment, the patch LGTM. Happy hacking, Miguel