[bug#46598] [PATCH] gnu: Add vitetris.

[Nicolas Goaziou <mail@nicolasgoaziou.fr>]

Hello,

Stefan Reichör <stefan@xsteve.at> writes:

> * gnu/packages/games.scm (vitetris): New variable.

Thank you! Some comments follow.


> +    (version "v0.59.1")

You're mixing the version and the tag name. The version should be
"0.59.1"...

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/vicgeralds/vitetris")
> +             (commit version)))

... and the commit should be (string-append "v" version).

> +                      ;; src/src-conf.mk must be writable for the build step
> +                      (chmod "src/src-conf.mk" #o666)

I suggest (make-file-writeable "src/src-conf.mk")

> +                      #t)))

You can omit it.

> +       #:tests? #f   ; no test
> +       #:make-flags
> +       (list ,(string-append "CC=" (cc-for-target))
> +             (string-append "DESTDIR=" (assoc-ref %outputs "out")))))

There is an issue here.  The install script does not install executable
in %out/bin, but in %out/usr/local/bin.

> +    (home-page "http://victornils.net/tetris/")
> +    (synopsis "Terminal-based tetris clone")

tetris -> Tetris

> +    (description "Classic multiplayer tetris for the terminal.")

I suggest:

  Vitetris is a classic multiplayer Tetris clone for the terminal.


Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou