From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8CJAFiVGLmDNSwAA0tVLHw (envelope-from ) for ; Thu, 18 Feb 2021 10:49:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id ADwHEiVGLmDZUgAAbx9fmQ (envelope-from ) for ; Thu, 18 Feb 2021 10:49:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A5F571CE71 for ; Thu, 18 Feb 2021 11:49:08 +0100 (CET) Received: from localhost ([::1]:50102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCgrr-0002i7-Os for larch@yhetil.org; Thu, 18 Feb 2021 05:49:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCgrl-0002ht-V6 for guix-patches@gnu.org; Thu, 18 Feb 2021 05:49:01 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34636) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lCgrl-0001oP-NA for guix-patches@gnu.org; Thu, 18 Feb 2021 05:49:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lCgrl-0004XG-Jk for guix-patches@gnu.org; Thu, 18 Feb 2021 05:49:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46598] [PATCH] gnu: Add vitetris. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 18 Feb 2021 10:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Stefan =?UTF-8?Q?Reich=C3=B6r?= Cc: 46598@debbugs.gnu.org Received: via spool by 46598-submit@debbugs.gnu.org id=B46598.161364528517358 (code B ref 46598); Thu, 18 Feb 2021 10:49:01 +0000 Received: (at 46598) by debbugs.gnu.org; 18 Feb 2021 10:48:05 +0000 Received: from localhost ([127.0.0.1]:46182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lCgqr-0004Vu-9z for submit@debbugs.gnu.org; Thu, 18 Feb 2021 05:48:05 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:48813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lCgqp-0004VN-Hz for 46598@debbugs.gnu.org; Thu, 18 Feb 2021 05:48:04 -0500 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay11.mail.gandi.net (Postfix) with ESMTPSA id A0989100018; Thu, 18 Feb 2021 10:47:56 +0000 (UTC) From: Nicolas Goaziou References: <20210217200853.58442-1-stefan@xsteve.at> Date: Thu, 18 Feb 2021 11:47:55 +0100 In-Reply-To: <20210217200853.58442-1-stefan@xsteve.at> ("Stefan =?UTF-8?Q?Reich=C3=B6r?="'s message of "Wed, 17 Feb 2021 21:08:53 +0100") Message-ID: <87lfbld544.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.36 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: A5F571CE71 X-Spam-Score: -2.36 X-Migadu-Scanner: scn1.migadu.com X-TUID: OmpvS+/kYPu9 Hello, Stefan Reich=C3=B6r writes: > * gnu/packages/games.scm (vitetris): New variable. Thank you! Some comments follow. > + (version "v0.59.1") You're mixing the version and the tag name. The version should be "0.59.1"... > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/vicgeralds/vitetris") > + (commit version))) ... and the commit should be (string-append "v" version). > + ;; src/src-conf.mk must be writable for the build = step > + (chmod "src/src-conf.mk" #o666) I suggest (make-file-writeable "src/src-conf.mk") > + #t))) You can omit it. > + #:tests? #f ; no test > + #:make-flags > + (list ,(string-append "CC=3D" (cc-for-target)) > + (string-append "DESTDIR=3D" (assoc-ref %outputs "out"))))) There is an issue here. The install script does not install executable in %out/bin, but in %out/usr/local/bin. > + (home-page "http://victornils.net/tetris/") > + (synopsis "Terminal-based tetris clone") tetris -> Tetris > + (description "Classic multiplayer tetris for the terminal.") I suggest: Vitetris is a classic multiplayer Tetris clone for the terminal. Could you send an updated patch? Regards, --=20 Nicolas Goaziou