all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Xinglu Chen <public@yoctocell.xyz>
Cc: 50615@debbugs.gnu.org
Subject: [bug#50615] [PATCH] gnu: grokmirror: Update to 2.0.11.
Date: Thu, 16 Sep 2021 23:06:11 -0400	[thread overview]
Message-ID: <87lf3vvr30.fsf@kyleam.com> (raw)
In-Reply-To: <a8f912efa11e1afe72244723dc7771709816a529.1631782039.git.public@yoctocell.xyz>

Xinglu Chen writes:

> * gnu/packages/version-control.scm (grokmirror): Update to 2.0.11.
> [arguments]<#:phases>: Don’t return #t.

Thanks for keeping grokmirror up to date.

>  (define-public grokmirror
[...]
> @@ -2487,8 +2487,7 @@ Mercurial, Bazaar, Darcs, CVS, Fossil, and Veracity.")

Unrelated sidenote: you could get a more informative hunk header for
your patches by defining a custom one (more details in the gitattributes
manpage).

>                                          "/man/man1/")))
>                 (mkdir-p man)
>                 (for-each (lambda (file) (install-file file man))
> -                         (find-files "." "\\.1$")))
> -             #t)))))
> +                         (find-files "." "\\.1$"))))))))

Oops, sorry about the unnecessary #t.  I did a quick search of the
lists/manual but didn't find any pointers/discussion.  What's the way to
decide when a custom phase should return #t (like in the below snippet
from the manual)?

--8<---------------cut here---------------start------------->8---
(modify-phases %standard-phases
  (add-after 'install 'fix-egrep-and-fgrep
    ;; Patch 'egrep' and 'fgrep' to execute 'grep' via its
    ;; absolute file name instead of searching for it in $PATH.
    (lambda* (#:key outputs #:allow-other-keys)
      (let* ((out (assoc-ref outputs "out"))
             (bin (string-append out "/bin")))
        (substitute* (list (string-append bin "/egrep")
                           (string-append bin "/fgrep"))
          (("^exec grep")
           (string-append "exec " bin "/grep")))
        #t))))
--8<---------------cut here---------------end--------------->8---




  reply	other threads:[~2021-09-17  3:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-16  8:47 [bug#50615] [PATCH] gnu: grokmirror: Update to 2.0.11 Xinglu Chen
2021-09-17  3:06 ` Kyle Meyer [this message]
2021-09-17  8:33   ` Xinglu Chen
2021-09-17 10:48     ` Kyle Meyer
2021-09-30 21:00 ` bug#50615: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lf3vvr30.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=50615@debbugs.gnu.org \
    --cc=public@yoctocell.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.