From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UAn7BWAGRGE+EwAAgWs5BA (envelope-from ) for ; Fri, 17 Sep 2021 05:07:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8AyYAWAGRGFhfwAAbx9fmQ (envelope-from ) for ; Fri, 17 Sep 2021 03:07:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5775E6358 for ; Fri, 17 Sep 2021 05:07:11 +0200 (CEST) Received: from localhost ([::1]:38850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mR4DW-00068t-2v for larch@yhetil.org; Thu, 16 Sep 2021 23:07:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mR4DO-00068i-WB for guix-patches@gnu.org; Thu, 16 Sep 2021 23:07:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46599) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mR4DO-0005pJ-OX for guix-patches@gnu.org; Thu, 16 Sep 2021 23:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mR4DO-0001uM-Fo for guix-patches@gnu.org; Thu, 16 Sep 2021 23:07:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50615] [PATCH] gnu: grokmirror: Update to 2.0.11. Resent-From: Kyle Meyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 17 Sep 2021 03:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50615 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: 50615@debbugs.gnu.org Received: via spool by 50615-submit@debbugs.gnu.org id=B50615.16318479897289 (code B ref 50615); Fri, 17 Sep 2021 03:07:02 +0000 Received: (at 50615) by debbugs.gnu.org; 17 Sep 2021 03:06:29 +0000 Received: from localhost ([127.0.0.1]:58145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mR4Cq-0001tU-8o for submit@debbugs.gnu.org; Thu, 16 Sep 2021 23:06:29 -0400 Received: from out1.migadu.com ([91.121.223.63]:18399) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mR4Ck-0001tF-OZ for 50615@debbugs.gnu.org; Thu, 16 Sep 2021 23:06:27 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1631847980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J7nQGQXgvGTBzr7+r48dUjh1tcP4GtlqPhUkrGVgMUI=; b=jfV/9eYpVxn/8QrDrcP0WmGriQ9OFt4Tb9LC+9YP5zg3ckAoR/VSvklYO2UzmpkK+cKUGi RRcRqb5mVXESvWIvBrtfyLtuUUitwqu7KwGaultn4pLl/X1v+m2+x1LOqsTWp3rjMrJzB1 dlbFmIVU1Ipahvnl+tPdmS3hwN1ji4Pw8zsuZpMc3srjaNBE78uOd4htR7kaaSguD8r7pN kkCZQVsk+SdeD+AY55dmg/Zs9/MJiER9y0/XljNVm9TK63klPq0vPAhQ3wJ4/gPpJr4ttv 8LRIaBa0JEMn9MaK/L8A18dS9+KkkHePzosg5JLOFgyossekRwfg8sW29bZCxw== From: Kyle Meyer In-Reply-To: References: Date: Thu, 16 Sep 2021 23:06:11 -0400 Message-ID: <87lf3vvr30.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631848031; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=J7nQGQXgvGTBzr7+r48dUjh1tcP4GtlqPhUkrGVgMUI=; b=YR1DR4mhtC9NG50/enJfNTO6wmGi/CYP4Kmny6WxYeXpxp1OVpuOLS4bz091lI6/jf7SIo fG3J7ljeq4HSHH4yW6mLWOn/tPrWitPK//ngAT0P5PI9VR700VtwkqMxqZ3n8y5q1U8ptl EWappFtRfLPYOS8ZTmh1Wmq4j25ahREDHs7TKUHkMpdvxsgZrZ6LMd4IEAhTc6Z7lme/d1 S2V2+zjpgNrS5PorRo/t9efM5aNzJowRos9WZTTM8PkvGkQte9mcCAtzmHUck40NN/xHVH OED+zTiwyazRpAytrCJIQyOwQ5VQzPuVVJ0zQyzHwtEPMpgseP2buOP0gz7lLw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631848031; a=rsa-sha256; cv=none; b=nkxvW3VKlu8aG1DlIo/OY8lW/qaOuZGgxwEb9gFZwfpn+fPax8S2IblIijFOCq3K8JdHr0 rl+Qbmn9rLdyD5yUi7qbL+KOP8rdI3UZxe1dT90ynrBtQ2YAYtQHfWD6e58Ay2nue8/3eF 3H+MWQXwEU4UraJK+/MzIZ5wNWMsCNGMHr0y7meU0PdkrDh97E2qIkKnmbnykaW6KDh7kN lLr4F7APhl3gNhCYEeTO3dpYMRwpvd2mPImspJBNgBBCYnaogX421FSZ6376BRr/VFMtac aW4/FgkPFTcKtbd9sdhTQfG9S/R2sumzIKaAl9FbwC+/GASOKVt36mCO8Re3fQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kyleam.com header.s=key1 header.b="jfV/9eYp"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.40 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kyleam.com header.s=key1 header.b="jfV/9eYp"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5775E6358 X-Spam-Score: -1.40 X-Migadu-Scanner: scn1.migadu.com X-TUID: d/5m/NEWW/ZG Xinglu Chen writes: > * gnu/packages/version-control.scm (grokmirror): Update to 2.0.11. > [arguments]<#:phases>: Don=E2=80=99t return #t. Thanks for keeping grokmirror up to date. > (define-public grokmirror [...] > @@ -2487,8 +2487,7 @@ Mercurial, Bazaar, Darcs, CVS, Fossil, and Veracity= .") Unrelated sidenote: you could get a more informative hunk header for your patches by defining a custom one (more details in the gitattributes manpage). > "/man/man1/"))) > (mkdir-p man) > (for-each (lambda (file) (install-file file man)) > - (find-files "." "\\.1$"))) > - #t))))) > + (find-files "." "\\.1$")))))))) Oops, sorry about the unnecessary #t. I did a quick search of the lists/manual but didn't find any pointers/discussion. What's the way to decide when a custom phase should return #t (like in the below snippet from the manual)? --8<---------------cut here---------------start------------->8--- (modify-phases %standard-phases (add-after 'install 'fix-egrep-and-fgrep ;; Patch 'egrep' and 'fgrep' to execute 'grep' via its ;; absolute file name instead of searching for it in $PATH. (lambda* (#:key outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) (bin (string-append out "/bin"))) (substitute* (list (string-append bin "/egrep") (string-append bin "/fgrep")) (("^exec grep") (string-append "exec " bin "/grep"))) #t)))) --8<---------------cut here---------------end--------------->8---