From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Brandon Lucas <br@ndon.dk>
Cc: 53290@debbugs.gnu.org
Subject: [bug#53290] [PATCH] gnu: Add emacs-fennel-mode.
Date: Sun, 16 Jan 2022 10:17:16 +0100 [thread overview]
Message-ID: <87lezg11lv.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20220115215925.1542641-1-br@ndon.dk> (Brandon Lucas's message of "Sat, 15 Jan 2022 22:00:02 +0000")
Hello,
Brandon Lucas <br@ndon.dk> writes:
> * gnu/packages/emacs-xyz.scm (emacs-fennel-mode): New variable.
Thank you for this. Some comments follow.
> +(define-public emacs-fennel-mode
> + (let ((commit "54ed0792d0ac43a2d5db39741cf070c627368419")
> + (revision "0"))
> + (package
> + (name "emacs-fennel-mode")
> + (version (git-version "0.4.1" revision commit))
The commit hash you use matches the "0.4.1" version bump. Therefore you
can drop commit and revision binding, and use "0.4.1" in the version
field.
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://gitlab.com/technomancy/fennel-mode.git")
You can drop the ".git" suffix here. I think "./pre-inst-env guix lint
emacs-fennel-mode" should warn you about it.
> + (commit commit)))
Since you dropped commit binding, this should be (commit version)
> + (description
> + "Provides font-lock, indentation, navigation, and repl for Fennel code
> + within Emacs.")
Descriptions are expected to be full sentences. I suggest:
Fennel mode provides font-lock, indentation, navigation and REPL for
Fennel code within Emacs.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2022-01-16 9:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-15 22:00 [bug#53290] [PATCH] gnu: Add emacs-fennel-mode Brandon Lucas
2022-01-16 9:17 ` Nicolas Goaziou [this message]
2022-01-16 10:50 ` [bug#53290] [PATCH v2] " Brandon Lucas
2022-01-16 22:37 ` bug#53290: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lezg11lv.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=53290@debbugs.gnu.org \
--cc=br@ndon.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.