From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qP0xMtPi42FDNwAAgWs5BA (envelope-from ) for ; Sun, 16 Jan 2022 10:18:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id sMmJLtPi42E+TwEAauVa8A (envelope-from ) for ; Sun, 16 Jan 2022 10:18:11 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 911BA44EC5 for ; Sun, 16 Jan 2022 10:18:11 +0100 (CET) Received: from localhost ([::1]:60026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n91fu-00063P-4y for larch@yhetil.org; Sun, 16 Jan 2022 04:18:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n91fl-000631-Ua for guix-patches@gnu.org; Sun, 16 Jan 2022 04:18:01 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49566) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n91fl-00027S-LD for guix-patches@gnu.org; Sun, 16 Jan 2022 04:18:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n91fl-0000fE-I0 for guix-patches@gnu.org; Sun, 16 Jan 2022 04:18:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53290] [PATCH] gnu: Add emacs-fennel-mode. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 16 Jan 2022 09:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53290 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brandon Lucas Cc: 53290@debbugs.gnu.org Received: via spool by 53290-submit@debbugs.gnu.org id=B53290.16423246482510 (code B ref 53290); Sun, 16 Jan 2022 09:18:01 +0000 Received: (at 53290) by debbugs.gnu.org; 16 Jan 2022 09:17:28 +0000 Received: from localhost ([127.0.0.1]:42469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n91fD-0000eQ-Ti for submit@debbugs.gnu.org; Sun, 16 Jan 2022 04:17:28 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:44281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n91fB-0000e8-D4 for 53290@debbugs.gnu.org; Sun, 16 Jan 2022 04:17:26 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 1A14A40004; Sun, 16 Jan 2022 09:17:17 +0000 (UTC) From: Nicolas Goaziou References: <20220115215925.1542641-1-br@ndon.dk> Date: Sun, 16 Jan 2022 10:17:16 +0100 In-Reply-To: <20220115215925.1542641-1-br@ndon.dk> (Brandon Lucas's message of "Sat, 15 Jan 2022 22:00:02 +0000") Message-ID: <87lezg11lv.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642324691; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=mvpsWIaP72IbVbEsqNuAbPxWxVKbhdfiPv1UNw1Ucxc=; b=OkEyJ1G+AvzQ1JqwIx7yqE+uZaH5XmDUPe25mw5mJpyEGlkXnuoH2IrVr5EmFJKONra/e8 RiUi++iF4TbU5m2Y1JdReVewjSf9+5ChcBAfMLr9Ebx7qJrsPphTQf5F/puz1YgRQv3uJh rRuUiZRqdWivmqR0znvFxLlgpboyl1igzVq3gu1d9z72PRIf2ooA1bTBdTv1AkjKcLpHsR 3WYGhmBFbiayU0GhohaloceQpUkWyWbJ+AfhyNthoAWyHvmsVv/NP0K4BLgo5bFh+yw6eN uvpBWLTTHwBMGAKyIWS4X5axoKpP9cG90He6r0aEuJ3WMSCysoy5RU9u44Yn/Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642324691; a=rsa-sha256; cv=none; b=AFPcGSXSAr0SLEd1WrQx7fKEsqVq47aOsXLwUVYdte0KVEDV/aHlbTuhFsW0JztY1Urk0K SQtsjHrmb6wgSPu8YN8J2vhjPhqyX+DGbOJ6GqIRxBF/dANWFjMTA87eTbDrbt3F8SItYj ujTfSv7KV24TlpdOd5UppsZJV0SFeD2I6rXsUT/tIetDTALtlMBc5PJmqDDBca5eeo3cqk L26WmsqcKKyFDlPUYGb/t5ajNXPMSxhcdScLvXQ6n25CwClyZTw6+kyzRSXu1KKv0JfqWG Vz83asFjMVSmmdkhmCfmwp53DLiBFybkoB3MOvVXVgO23VNrcHeCB5R7/H3iSw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.22 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 911BA44EC5 X-Spam-Score: -3.22 X-Migadu-Scanner: scn1.migadu.com X-TUID: Uj1g5aHGANz3 Hello, Brandon Lucas writes: > * gnu/packages/emacs-xyz.scm (emacs-fennel-mode): New variable. Thank you for this. Some comments follow. > +(define-public emacs-fennel-mode > + (let ((commit "54ed0792d0ac43a2d5db39741cf070c627368419") > + (revision "0")) > + (package > + (name "emacs-fennel-mode") > + (version (git-version "0.4.1" revision commit)) The commit hash you use matches the "0.4.1" version bump. Therefore you can drop commit and revision binding, and use "0.4.1" in the version field. > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://gitlab.com/technomancy/fennel-mode.git") You can drop the ".git" suffix here. I think "./pre-inst-env guix lint emacs-fennel-mode" should warn you about it. > + (commit commit))) Since you dropped commit binding, this should be (commit version) > + (description > + "Provides font-lock, indentation, navigation, and repl for Fennel code > + within Emacs.") Descriptions are expected to be full sentences. I suggest: Fennel mode provides font-lock, indentation, navigation and REPL for Fennel code within Emacs. Could you send an updated patch? Regards, -- Nicolas Goaziou