* [bug#38115] [PATCH] gnu: Add dpf-plugins. @ 2019-11-08 8:58 Alexandros Theodotou 2019-11-10 22:45 ` Marius Bakke 0 siblings, 1 reply; 4+ messages in thread From: Alexandros Theodotou @ 2019-11-08 8:58 UTC (permalink / raw) To: 38115 From aebc4cded75e51f6c453a52cae10c9224d9e7df9 Mon Sep 17 00:00:00 2001 From: Alexandros Theodotou <alex@zrythm.org> Date: Fri, 8 Nov 2019 08:55:22 +0000 Subject: [PATCH] gnu: Add dpf-plugins. * gnu/packages/music.scm: (dpf-plugins): New variable. --- gnu/packages/music.scm | 47 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index a30765e87f..e78b01d4a3 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -24,6 +24,7 @@ ;;; Copyright © 2019 Jakob L. Kreuze <zerodaysfordays@sdf.lonestar.org> ;;; Copyright © 2019 raingloom <raingloom@protonmail.com> ;;; Copyright © 2019 David Wilson <david@daviwil.com> +;;; Copyright © 2019 Alexandros Theodotou <alex@zrythm.org> ;;; ;;; This file is part of GNU Guix. ;;; @@ -4699,3 +4700,49 @@ You can also get metadata about the playing track such as the artist and title for integration into status line generators or other command-line tools.") (home-page "https://github.com/altdesktop/playerctl") (license license:lgpl3+))) + +(define-public dpf-plugins + (package + (name "dpf-plugins") + (version "1.3") + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/DISTRHO/DPF-Plugins.git") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0a89hiqflg8y55aphiff64g9jli88lxzwzw4grfk48n7r1mp49hf")))) + (build-system gnu-build-system) + (arguments + `(#:tests? #f ; no "check" target + #:make-flags + (list (string-append "PREFIX=" (assoc-ref %outputs "out"))) + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'skip-dssi-binaries + (lambda _ + (substitute* "Makefile" + (("cp -r bin.*-dssi.*$") ":;\n")) + #t)) + (add-before 'build 'set-CC-variable + (lambda _ (setenv "CC" "gcc") #t)) + (delete 'configure)))) + (inputs + `(("cairo" ,cairo) + ("dssi" ,dssi) + ("mesa" ,mesa))) + (native-inputs + `(("pkg-config" ,pkg-config) + ("lv2" ,lv2))) + (home-page "https://github.com/DISTRHO/DPF-Plugins") + (synopsis "Audio plugin collection") + (description "Collection of DPF-based audio plugins in LADSPA, DSSI, LV2 and VST2 +formats. This package includes the following plugins: glBars, Kars, Max-Gen examples +(MaBitcrush, MaFreeverb, MaGigaverb, MaPitchshift), Mini-Series (3BandEQ. 3BandSplitter, +PingPongPan), ndc-Plugs (Amplitude Imposer, Cycle Shifter, Soul Force), MVerb, Nekobi, +and ProM.") + (license `(license:isc license:gpl3 license:lgpl3 license:mit license:gpl2)))) -- 2.24.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#38115] [PATCH] gnu: Add dpf-plugins. 2019-11-08 8:58 [bug#38115] [PATCH] gnu: Add dpf-plugins Alexandros Theodotou @ 2019-11-10 22:45 ` Marius Bakke 2019-11-11 4:48 ` Alexandros Theodotou 0 siblings, 1 reply; 4+ messages in thread From: Marius Bakke @ 2019-11-10 22:45 UTC (permalink / raw) To: Alexandros Theodotou, 38115 [-- Attachment #1: Type: text/plain, Size: 1305 bytes --] Alexandros Theodotou <alex@zrythm.org> writes: > From aebc4cded75e51f6c453a52cae10c9224d9e7df9 Mon Sep 17 00:00:00 2001 > From: Alexandros Theodotou <alex@zrythm.org> > Date: Fri, 8 Nov 2019 08:55:22 +0000 > Subject: [PATCH] gnu: Add dpf-plugins. > > * gnu/packages/music.scm: (dpf-plugins): New variable. [...] > + (arguments > + `(#:tests? #f ; no "check" target > + #:make-flags > + (list (string-append "PREFIX=" (assoc-ref %outputs "out"))) > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'skip-dssi-binaries > + (lambda _ > + (substitute* "Makefile" > + (("cp -r bin.*-dssi.*$") ":;\n")) > + #t)) Can you expand on this comment? What are these binaries, and why do we need to prevent them from being installed? > + (license `(license:isc license:gpl3 license:lgpl3 license:mit > license:gpl2)))) Does this work? I would expect each of the license entries to have to be 'unquoted', i.e. `(,license:isc). Alternatively you can use (list ...) here. When a package has multiple licenses like here, please add a comment about it. Is there a "main" license, (roughly) which files are under what license? Apart from that LGTM. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 487 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#38115] [PATCH] gnu: Add dpf-plugins. 2019-11-10 22:45 ` Marius Bakke @ 2019-11-11 4:48 ` Alexandros Theodotou 2019-11-13 22:30 ` bug#38115: " Marius Bakke 0 siblings, 1 reply; 4+ messages in thread From: Alexandros Theodotou @ 2019-11-11 4:48 UTC (permalink / raw) To: Marius Bakke, 38115 [-- Attachment #1.1: Type: text/plain, Size: 1153 bytes --] > > + (arguments > > + `(#:tests? #f ; no "check" target > > + #:make-flags > > + (list (string-append "PREFIX=" (assoc-ref %outputs "out"))) > > + #:phases > > + (modify-phases %standard-phases > > + (add-after 'unpack 'skip-dssi-binaries > > + (lambda _ > > + (substitute* "Makefile" > > + (("cp -r bin.*-dssi.*$") ":;\n")) > > + #t)) > > Can you expand on this comment? What are these binaries, and why do > we > need to prevent them from being installed? I was having trouble building them, but I managed to get them building now (was missing liblo). Removed this part > > > + (license `(license:isc license:gpl3 license:lgpl3 license:mit > > license:gpl2)))) > > Does this work? I would expect each of the license entries to have > to > be 'unquoted', i.e. `(,license:isc). Alternatively you can use (list > ...) here. > > When a package has multiple licenses like here, please add a comment > about it. Is there a "main" license, (roughly) which files are under > what license? Fixed and added more info [-- Attachment #1.2: 0001-gnu-Add-dpf-plugins.patch --] [-- Type: text/x-patch, Size: 2735 bytes --] From 065b91fd765d8df510bcf969c9f41ae792733632 Mon Sep 17 00:00:00 2001 From: Alexandros Theodotou <alex@zrythm.org> Date: Fri, 8 Nov 2019 08:55:22 +0000 Subject: [PATCH] gnu: Add dpf-plugins. * gnu/packages/music.scm: (dpf-plugins): New variable. --- gnu/packages/music.scm | 48 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index 2f023685df..784462e56d 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -4737,3 +4737,51 @@ for integration into status line generators or other command-line tools.") effects. It contains a bitcrusher, delay, distortion, equalizer, compressor, and reverb.") (license license:gpl2+))) + +(define-public dpf-plugins + (package + (name "dpf-plugins") + (version "1.3") + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/DISTRHO/DPF-Plugins.git") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1hsfmpv3kvpiwk8nfw9xpaipzy0n27i83y2v1yr93lznwm5rqrbs")))) + (build-system gnu-build-system) + (arguments + `(#:tests? #f ; no "check" target + #:make-flags + (list (string-append "PREFIX=" (assoc-ref %outputs "out"))) + #:phases + (modify-phases %standard-phases + (add-before 'build 'set-CC-variable + (lambda _ (setenv "CC" "gcc") #t)) + (delete 'configure)))) + (inputs + `(("cairo" ,cairo) + ("liblo" ,liblo) ; for dssi plugins + ("jack" ,jack-1) ; for standalone applications + ("mesa" ,mesa))) + (native-inputs + `(("pkg-config" ,pkg-config) + ("dssi" ,dssi) + ("lv2" ,lv2))) + (home-page "https://github.com/DISTRHO/DPF-Plugins") + (synopsis "Audio plugin collection") + (description "Collection of audio plugins built with the DISTRHO Plugin +Framework (DPF) available in LADSPA, DSSI, LV2 and VST2 formats. This +package includes the following plugins: glBars, Kars, Max-Gen examples +(MaBitcrush, MaFreeverb, MaGigaverb, MaPitchshift), Mini-Series (3BandEQ, +3BandSplitter, PingPongPan), ndc-Plugs (Amplitude Imposer, Cycle Shifter, +Soul Force), MVerb, Nekobi, and ProM.") + ;; This package consists of several plugins refactored to use the + ;; DISTHRO Plugin Framework (DPF). Different copyrights and licenses + ;; apply to different plugins. The root LICENSE file has a table with + ;; license information for each plugin and paths to each license + (license (list license:isc license:gpl3 license:lgpl3 license:expat license:gpl2)))) -- 2.24.0 [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#38115: [PATCH] gnu: Add dpf-plugins. 2019-11-11 4:48 ` Alexandros Theodotou @ 2019-11-13 22:30 ` Marius Bakke 0 siblings, 0 replies; 4+ messages in thread From: Marius Bakke @ 2019-11-13 22:30 UTC (permalink / raw) To: Alexandros Theodotou, 38115-done [-- Attachment #1: Type: text/plain, Size: 325 bytes --] Alexandros Theodotou <alex@zrythm.org> writes: > From 065b91fd765d8df510bcf969c9f41ae792733632 Mon Sep 17 00:00:00 2001 > From: Alexandros Theodotou <alex@zrythm.org> > Date: Fri, 8 Nov 2019 08:55:22 +0000 > Subject: [PATCH] gnu: Add dpf-plugins. > > * gnu/packages/music.scm: (dpf-plugins): New variable. Applied, thanks! [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 487 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-13 22:31 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-11-08 8:58 [bug#38115] [PATCH] gnu: Add dpf-plugins Alexandros Theodotou 2019-11-10 22:45 ` Marius Bakke 2019-11-11 4:48 ` Alexandros Theodotou 2019-11-13 22:30 ` bug#38115: " Marius Bakke
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/guix.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.