From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Jai Vetrivelan <jaivetrivelan@gmail.com>
Cc: 53851@debbugs.gnu.org
Subject: [bug#53851] [PATCH] gnu: Add emacs-latex-preview-pane.
Date: Tue, 08 Feb 2022 01:16:38 +0100 [thread overview]
Message-ID: <87k0e61ac9.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87o83i6409.fsf@gmail.com>
Hello,
Jai Vetrivelan <jaivetrivelan@gmail.com> writes:
> Subject: [PATCH] gnu: Add emacs-latex-preview-pane.
Thank you.
>
> * gnu/packages/emacs-xyz.scm (emacs-latex-preview-pane): new variable.
Nitpick: capitalize "New".
> + (arguments
> + ;; The welcome and error message templates are in .txt format.
> + '(#:include '("\\.el$" "\\.txt$")))
You can switch to G-expressions:
(arguments
(list
#:include #~(list "\\.el$" "\\.txt$")))
This is a bit more verbose, tho.
> + (home-page "https://www.emacswiki.org/emacs/LaTeXPreviewPane")
Why is the home-page pointing to EmacsWiki? Shouldn't it point to the
repository instead?
> + (synopsis "Makes LaTeX editing less painful by providing a updatable
> +preview pane")
I suggest something shorter and more neutral:
"Preview pane to ease LaTeX editing in Emacs"
> + (description "@code{latex-preview-pane} is a minor mode for Emacs that
> +enables you to preview your LaTeX files directly in Emacs. It supports PDF
> +previews, your choice of pdflatex or xelatex, and it highlights errors in your
> +LaTeX buffer.")
Nitpick: I would remove all "your" references…
"@code{latex-preview-pane} is a minor mode for previewing LaTeX files
directly in Emacs. It supports PDF previews, with either
@command{pdflatex} or @command{xelatex}, and highlights errors in the
LaTeX buffer.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2022-02-08 0:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 16:22 [bug#53851] [PATCH] gnu: Add emacs-latex-preview-pane Jai Vetrivelan
2022-02-08 0:16 ` Nicolas Goaziou [this message]
2022-02-08 0:54 ` Jai Vetrivelan
2022-02-08 17:23 ` bug#53851: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0e61ac9.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=53851@debbugs.gnu.org \
--cc=jaivetrivelan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.