From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EBc9GYS2AWKaQQEAgWs5BA (envelope-from ) for ; Tue, 08 Feb 2022 01:17:08 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id CHUIFoS2AWLW/QAAauVa8A (envelope-from ) for ; Tue, 08 Feb 2022 01:17:08 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E85B73A37B for ; Tue, 8 Feb 2022 01:17:07 +0100 (CET) Received: from localhost ([::1]:38094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHEBu-0005XF-Jq for larch@yhetil.org; Mon, 07 Feb 2022 19:17:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHEBq-0005VT-50 for guix-patches@gnu.org; Mon, 07 Feb 2022 19:17:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50389) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHEBp-0005zb-Sa for guix-patches@gnu.org; Mon, 07 Feb 2022 19:17:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHEBp-0000Ah-Ox for guix-patches@gnu.org; Mon, 07 Feb 2022 19:17:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53851] [PATCH] gnu: Add emacs-latex-preview-pane. In-Reply-To: <87o83i6409.fsf@gmail.com> Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Feb 2022 00:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53851 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jai Vetrivelan Cc: 53851@debbugs.gnu.org Received: via spool by 53851-submit@debbugs.gnu.org id=B53851.1644279407622 (code B ref 53851); Tue, 08 Feb 2022 00:17:01 +0000 Received: (at 53851) by debbugs.gnu.org; 8 Feb 2022 00:16:47 +0000 Received: from localhost ([127.0.0.1]:44286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHEBb-00009y-CW for submit@debbugs.gnu.org; Mon, 07 Feb 2022 19:16:47 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:37115) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHEBa-00009k-5R for 53851@debbugs.gnu.org; Mon, 07 Feb 2022 19:16:46 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 6F9EB200003; Tue, 8 Feb 2022 00:16:39 +0000 (UTC) From: Nicolas Goaziou References: <87o83i6409.fsf@gmail.com> Date: Tue, 08 Feb 2022 01:16:38 +0100 Message-ID: <87k0e61ac9.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644279428; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=sSmC5nLNTTKo/2g3Ey/4/eXAW4n6UG2Ra5/PHGtd3MY=; b=pSmJ3HyQ3aNOTUnYMVeo/JWTX9irinBStCe6MH+LJ/6uEKJyCmTtD3X6OBEV0Zdbx3vJl0 3++U+uipz2l+TwD2nrTSDdU4MFR3fpX8FTeqVNJbFocHi56nKK+6dtcU9hHUEE4O+58O13 qAWCmK3KV/6BuLeacOda0TNzU2Nfxauufu0faQt5iN7CVn2nC1gi7jw2Cn1fKCMnZ0et/M Z3cVFiiAqpe55BFyvRtdAxzMCQZ0Xu4XM6NRmTsqMww0IjDl31JTXVBj72MIkd/pXp2WRT Jib13nolvTJoaDRJ30oxyB8STEYpqlyOVhHuOJrVj9RYMt5O+CjUijBoBsAQsw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644279428; a=rsa-sha256; cv=none; b=WIPLweO0uJzEzB616HRBbi0f73X5/Se+zB681Ut5J2mPf7fS5h7zE+jL8LU/WsD/5dg+c6 okqn7zG2wHP4oVWbLRAkJw4dtYRede/zK6RMpTM06nJNoapfd84RQ1TH5Xdiy7WKQFWt0x Sc28EU7tzoAmgUoKidwzm3eqHCGH3cEcrlkq8sNO7VXh2YigikSmPxwYQoHdi3ZWaB7B7d 62c6VNb2CnzVEmPbZTEuptqFVdUXQlFQyHUArt+CXHA/OTDmHUfuQ8nzEJS2WH7F//R6mg YEszIiS/ac+vDdtz0D65hMH0q4i245uz5mdssGeThwIfbe1Yb56BEzfWq7/18A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.23 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E85B73A37B X-Spam-Score: -3.23 X-Migadu-Scanner: scn1.migadu.com X-TUID: cA74+tUHe+Jm Hello, Jai Vetrivelan writes: > Subject: [PATCH] gnu: Add emacs-latex-preview-pane. Thank you. > > * gnu/packages/emacs-xyz.scm (emacs-latex-preview-pane): new variable. Nitpick: capitalize "New". > + (arguments > + ;; The welcome and error message templates are in .txt format. > + '(#:include '("\\.el$" "\\.txt$"))) You can switch to G-expressions: (arguments (list #:include #~(list "\\.el$" "\\.txt$"))) This is a bit more verbose, tho. > + (home-page "https://www.emacswiki.org/emacs/LaTeXPreviewPane") Why is the home-page pointing to EmacsWiki? Shouldn't it point to the repository instead? > + (synopsis "Makes LaTeX editing less painful by providing a updata= ble > +preview pane") I suggest something shorter and more neutral: "Preview pane to ease LaTeX editing in Emacs" > + (description "@code{latex-preview-pane} is a minor mode for Emacs= that > +enables you to preview your LaTeX files directly in Emacs. It supports P= DF > +previews, your choice of pdflatex or xelatex, and it highlights errors i= n your > +LaTeX buffer.") Nitpick: I would remove all "your" references=E2=80=A6 "@code{latex-preview-pane} is a minor mode for previewing LaTeX files directly in Emacs. It supports PDF previews, with either @command{pdflatex} or @command{xelatex}, and highlights errors in the LaTeX buffer. Could you send an updated patch? Regards, --=20 Nicolas Goaziou