From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 54368-done@debbugs.gnu.org
Subject: bug#54368: [PATCH 0/4] Add Btrfs RAID10 install tests.
Date: Sat, 19 Mar 2022 11:31:35 -0400 [thread overview]
Message-ID: <87k0cq3qnc.fsf@gmail.com> (raw)
In-Reply-To: <87bky38upu.fsf_-_@gnu.org> (Mathieu Othacehe's message of "Fri, 18 Mar 2022 10:40:13 +0100")
Hi Mathieu,
Mathieu Othacehe <othacehe@gnu.org> writes:
> Hello Maxim,
>
> This looks great! I created a dedicated jobset here:
> https://ci.guix.gnu.org/jobset/wip-btrfs-raid-tests to check everything
> is still running fine.
>
>> +OS to install TARGET-OS. Return the VM disk images of TARGET-SIZE bytes
>> +containing the installed system. Unless providing OS, the PACKAGES will be
>> +added to the packages defined in INSTALLATION-OS (from (gnu system install)).
>> +NUMBER-OF-DISKS can be used to specify a number of disks different than one,
>> +such as for RAID systems."
>
> I'm having troubles understanding the "Unless providing OS" part of the
> sentence, but that's also because this mechanism of adding packages to
> the default OS definition is tricky.
>
> Maybe we should augment the OS definition with those packages
> unconditionally in the body of the "run-install" procedure.
This is now done unconditionally. I've also fixed the typo reported in
another email on this thread, thank you!
Retested with 'make check-system TESTS=btrfs-raid10-root-os' and pushed
with commit b45a301618.
Thanks for the review!
Maxim
next prev parent reply other threads:[~2022-03-19 15:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-13 5:40 [bug#54368] [PATCH 0/4] Add Btrfs RAID10 install tests Maxim Cournoyer
2022-03-13 5:43 ` [bug#54368] [PATCH 1/4] tests: install: Adjust the timeouts on two failing tests Maxim Cournoyer
2022-03-13 5:43 ` [bug#54368] [PATCH 2/4] tests: install: Streamline 'qemu-command/writable-image' Maxim Cournoyer
2022-03-13 5:43 ` [bug#54368] [PATCH 3/4] tests: install: Enable the use of multiple disk devices for tests Maxim Cournoyer
2022-03-18 9:40 ` [bug#54368] [PATCH 0/4] Add Btrfs RAID10 install tests Mathieu Othacehe
2022-03-18 13:28 ` Maxim Cournoyer
2022-03-19 15:31 ` Maxim Cournoyer [this message]
2022-03-18 9:41 ` Mathieu Othacehe
2022-03-18 13:31 ` Maxim Cournoyer
2022-03-18 15:26 ` Mathieu Othacehe
2022-03-13 5:43 ` [bug#54368] [PATCH 4/4] tests: install: Add two new Btrfs RAID10 install test Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0cq3qnc.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=54368-done@debbugs.gnu.org \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.