From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GAlAMH33NWKcawAAgWs5BA (envelope-from ) for ; Sat, 19 Mar 2022 16:32:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id CDHLKH33NWJ2ZwAAG6o9tA (envelope-from ) for ; Sat, 19 Mar 2022 16:32:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 49DBE198B5 for ; Sat, 19 Mar 2022 16:32:13 +0100 (CET) Received: from localhost ([::1]:45782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVb3r-00016K-HD for larch@yhetil.org; Sat, 19 Mar 2022 11:32:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVb3i-00015o-CL for guix-patches@gnu.org; Sat, 19 Mar 2022 11:32:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38306) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVb3i-00012l-3p for guix-patches@gnu.org; Sat, 19 Mar 2022 11:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVb3i-0003rh-0r for guix-patches@gnu.org; Sat, 19 Mar 2022 11:32:02 -0400 Subject: bug#54368: [PATCH 0/4] Add Btrfs RAID10 install tests. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sat, 19 Mar 2022 15:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 54368 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 54368-done@debbugs.gnu.org Mail-Followup-To: 54368@debbugs.gnu.org, maxim.cournoyer@gmail.com, maxim.cournoyer@gmail.com Received: via spool by 54368-done@debbugs.gnu.org id=D54368.164770390414820 (code D ref 54368); Sat, 19 Mar 2022 15:32:01 +0000 Received: (at 54368-done) by debbugs.gnu.org; 19 Mar 2022 15:31:44 +0000 Received: from localhost ([127.0.0.1]:60434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVb3P-0003qy-Ub for submit@debbugs.gnu.org; Sat, 19 Mar 2022 11:31:44 -0400 Received: from mail-qk1-f169.google.com ([209.85.222.169]:45789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVb3P-0003qn-1K for 54368-done@debbugs.gnu.org; Sat, 19 Mar 2022 11:31:43 -0400 Received: by mail-qk1-f169.google.com with SMTP id h196so8820358qke.12 for <54368-done@debbugs.gnu.org>; Sat, 19 Mar 2022 08:31:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=5uScJ9bqCZH7a0NHWruTP0XjOyT3qbyIgjwmHZetAHA=; b=PV92K8HHdQGt1IN3TrIr+B8EgajYBVp/6wJymho8BRu/lyceyzJDdnth6KNh1sHc6f jsgPflDeRoCKwyLoLjsz/SpANHbaoSCTbqsTNfixB33HnnXOciJ+UQsiUPp5KaQl99Ih WchBrrvo2Uzyf9acmrDG0Cbb5oF4ialLYEwnGuqOzKx5NHVmBGbTGg2Uj94x2glHo9Lg kSHP/PWN0N4oUU4yD/l6jmVo/O/t+CoOoyaP5ZvfQsqJpwhiw5INXq7EDA7g0U5982ff dt495bPZq838716aCKely9toccP5cibbnpVcXX5n3wsxEeYNVMnfWZV9MOJ+DJ/XX3c8 tSeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=5uScJ9bqCZH7a0NHWruTP0XjOyT3qbyIgjwmHZetAHA=; b=WuuKNFP4A+f/SRsVskc9PjyBFPXf9ttX9BR2Pi0wI8Uq7nxvQVmkkF94tQt85NTpzZ M3Eco0s4uENji1OXyjNszZsnT1ePBp4iuwVX6+X7RVkKYXWREMoA0nKP0RectV4t+r/y OvpGCYLy9Uz794vptDbT0AJYkWlAnC+caVPL3jmTcds0SrfQqk+ZKDO4BOm44Ps2uhGM xasq+pK9sVcfqeQhLB2zTS2k1rNPX3XlFIcZLptiNNo/Mz9GUVifxQcLl310STfjhGmW OoGLAd+ysphDf7bKvs7miSefb5kKExgJbaheUA5brdwrMPBwgbrldl+cnqEvia2Wf1Xv NujQ== X-Gm-Message-State: AOAM530wd24S4MY2suhArDXx7mqokqKtY7TFNOwhVThg8BGwyO/LaMzZ iXh491FDMU0luRm2adWJiulsRFBDums= X-Google-Smtp-Source: ABdhPJwfXkXRjTxkPnrPvaSL7oUmROL+zZqykxvqpevJE+Fb+uU9GfKekcIT99erSesEHV/HgZbU4g== X-Received: by 2002:a05:620a:4403:b0:67d:b751:361f with SMTP id v3-20020a05620a440300b0067db751361fmr8724639qkp.347.1647703897268; Sat, 19 Mar 2022 08:31:37 -0700 (PDT) Received: from hurd (dsl-10-132-234.b2b2c.ca. [72.10.132.234]) by smtp.gmail.com with ESMTPSA id v12-20020a05622a130c00b002e1b3ccd9adsm8190723qtk.79.2022.03.19.08.31.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Mar 2022 08:31:36 -0700 (PDT) From: Maxim Cournoyer References: <20220313054356.17578-1-maxim.cournoyer@gmail.com> <20220313054356.17578-3-maxim.cournoyer@gmail.com> <87bky38upu.fsf_-_@gnu.org> Date: Sat, 19 Mar 2022 11:31:35 -0400 In-Reply-To: <87bky38upu.fsf_-_@gnu.org> (Mathieu Othacehe's message of "Fri, 18 Mar 2022 10:40:13 +0100") Message-ID: <87k0cq3qnc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647703933; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=5uScJ9bqCZH7a0NHWruTP0XjOyT3qbyIgjwmHZetAHA=; b=WmXhSYUwj8fmvK5mmIFEnXn63zhLHkIflLvtsID5h8NkcZk+J70QHkZqo8nzaTGUBTM0Tg pEtHk+F/FefVivd0FAYSyao7bCype/9SYXdzsR5N1234DxVC4GTEq/6/I9klyxT6/HedFI I3xLjebCxMxNP6Vp/G50YiVsV6FaOX/idx6paCOkVwQGtDVX/OMUQ0/hHOIEz/4OqMqIm0 dtQiDbvbu5W5w5CY77MDB6A9dgusru1ceK8Lkut0a9n6dxM0AMyQxR3frVkgAwI6lFh3nA ynjDu4S6acHx3XohB3jq9yBemFd0sPwwZAD1ju6KthxhkUK7KL7vUvHZbs0o2A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647703933; a=rsa-sha256; cv=none; b=g9lMBr/AijgWbJ2gvj+QsYyvJozsusgSF6VB3Nuift3TInahiyNF+ixElRolJYm1u4g5KV gLZPgBfVErqLQ/9cYuP7PddXxhp3ZLxBT0DFlsfgZ2Rb+aIMllAgvLUkPmz4oLw3BwntaG uCZ0iyyPYNfRFo6g/d9n35aeJoeVAGTZLCr0vQGRs+eSv5xFa9dLwsqd19whpboZwy+vt+ 3tlN4v3TuxT/jWi5IEanljdEbKyNMf6dFvw4TVm7LbFMnteX/4VUVPc90hSdCmRsDEKdHw BU5uC4jy0rU62Og5OS+PiLPGUvCsDvZv6mfSoFCVomU4x65qn591y5nfp3+Tag== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=PV92K8HH; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.96 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=PV92K8HH; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 49DBE198B5 X-Spam-Score: 5.96 X-Migadu-Scanner: scn0.migadu.com X-TUID: 5f2YR/ZQcawe Hi Mathieu, Mathieu Othacehe writes: > Hello Maxim, > > This looks great! I created a dedicated jobset here: > https://ci.guix.gnu.org/jobset/wip-btrfs-raid-tests to check everything > is still running fine. > >> +OS to install TARGET-OS. Return the VM disk images of TARGET-SIZE bytes >> +containing the installed system. Unless providing OS, the PACKAGES will be >> +added to the packages defined in INSTALLATION-OS (from (gnu system install)). >> +NUMBER-OF-DISKS can be used to specify a number of disks different than one, >> +such as for RAID systems." > > I'm having troubles understanding the "Unless providing OS" part of the > sentence, but that's also because this mechanism of adding packages to > the default OS definition is tricky. > > Maybe we should augment the OS definition with those packages > unconditionally in the body of the "run-install" procedure. This is now done unconditionally. I've also fixed the typo reported in another email on this thread, thank you! Retested with 'make check-system TESTS=btrfs-raid10-root-os' and pushed with commit b45a301618. Thanks for the review! Maxim