From: ludo@gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 25917@debbugs.gnu.org
Subject: bug#25917: [PATCH] file-systems: Factorize file-system-packages.
Date: Sat, 18 Mar 2017 12:04:40 +0100 [thread overview]
Message-ID: <87inn6alrr.fsf@gnu.org> (raw)
In-Reply-To: <20170317131958.734cdfba@scratchpost.org> (Danny Milosavljevic's message of "Fri, 17 Mar 2017 16:02:53 +0100")
Danny Milosavljevic <dannym@scratchpost.org> skribis:
> I'd like to make the following change to guix/build/utils.scm :
>
> diff --git a/guix/build/utils.scm b/guix/build/utils.scm
> index bc6f11415..ca6360ed4 100644
> --- a/guix/build/utils.scm
> +++ b/guix/build/utils.scm
> @@ -409,7 +409,8 @@ for under the directories designated by FILES. For example:
> #:key
> (separator ":")
> (type 'directory)
> - pattern)
> + pattern
> + keep-previous-path?)
> "Look for each of FILES of the given TYPE (a symbol as returned by
> 'stat:type') in INPUT-DIRS. Set ENV-VAR to a SEPARATOR-separated path
> accordingly. Example:
> @@ -430,7 +431,13 @@ denoting file names to look for under the directories designated by FILES:
> (let* ((path (search-path-as-list files input-dirs
> #:type type
> #:pattern pattern))
> - (value (list->search-path-as-string path separator)))
> + (value (list->search-path-as-string path separator))
> + (previous-path (getenv env-var))
> + (value (if (and keep-previous-path?
> + previous-path
> + (not (string-null? previous-path)))
> + (string-append value ":" previous-path)
> + value)))
> (if (string-null? value)
> (begin
> ;; Never set ENV-VAR to an empty string because often, the empty
>
> Would that rebuild the world, though?
Yep. I don’t think that is needed though: we can use
‘set-path-environment-variables’ like your patch did to set PATH
precisely.
Thanks,
Ludo’.
next prev parent reply other threads:[~2017-03-18 11:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 16:38 bug#25917: operating-system file-system with (check? #t) but (needed-for-boot #f) pauses boot until user interaction Danny Milosavljevic
2017-03-11 11:21 ` Ludovic Courtès
2017-03-12 16:56 ` bug#25917: [PATCH] services: Don't check filesystem even if #:check? if not #:needed-for-boot Danny Milosavljevic
2017-03-13 9:01 ` Ludovic Courtès
2017-03-13 19:55 ` Danny Milosavljevic
2017-03-14 8:41 ` Ludovic Courtès
2017-03-14 19:18 ` Danny Milosavljevic
2017-03-14 20:18 ` Ludovic Courtès
2017-03-12 16:59 ` bug#25917: [PATCH v2] services: If a filesystem is not marked as needed for boot, don't check it even if told to check it Danny Milosavljevic
2017-03-16 17:40 ` bug#25917: [PATCH] file-systems: Factorize file-system-packages Danny Milosavljevic
2017-03-17 9:03 ` Ludovic Courtès
2017-03-17 12:19 ` Danny Milosavljevic
2017-03-18 11:00 ` Ludovic Courtès
2017-03-18 11:04 ` Ludovic Courtès [this message]
2017-03-18 9:42 ` Danny Milosavljevic
2017-03-18 14:06 ` bug#25917: [PATCH v2] services: file-system-shepherd-service: Make it find the fsck programs Danny Milosavljevic
2017-03-19 15:44 ` Ludovic Courtès
2017-04-22 23:34 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inn6alrr.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=25917@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.