From: Danny Milosavljevic <dannym@scratchpost.org>
To: 25917@debbugs.gnu.org, ludo@gnu.org
Subject: bug#25917: [PATCH v2] services: file-system-shepherd-service: Make it find the fsck programs.
Date: Sat, 18 Mar 2017 15:06:32 +0100 [thread overview]
Message-ID: <20170318140632.1778-1-dannym@scratchpost.org> (raw)
In-Reply-To: <20170316174029.1663-1-dannym@scratchpost.org>
* gnu/services/base.scm (file-system-shepherd-service): Use
file-system-packages.
---
gnu/services/base.scm | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 5298a11f6..ab5030146 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -274,7 +274,8 @@ FILE-SYSTEM."
(options (file-system-options file-system))
(check? (file-system-check? file-system))
(create? (file-system-create-mount-point? file-system))
- (dependencies (file-system-dependencies file-system)))
+ (dependencies (file-system-dependencies file-system))
+ (packages (file-system-packages (list file-system))))
(and (file-system-mount? file-system)
(with-imported-modules '((gnu build file-systems)
(guix build bournish))
@@ -292,11 +293,12 @@ FILE-SYSTEM."
;; Make sure fsck.ext2 & co. can be found.
(dynamic-wind
(lambda ()
- (setenv "PATH"
- (string-append
- #$e2fsprogs "/sbin:"
- "/run/current-system/profile/sbin:"
- $PATH)))
+ ;; Don’t display the PATH settings.
+ (with-output-to-port (%make-void-port "w")
+ (lambda ()
+ (set-path-environment-variable "PATH"
+ '("bin" "sbin")
+ '#$packages))))
(lambda ()
(mount-file-system
`(#$device #$title #$target #$type #$flags
next prev parent reply other threads:[~2017-03-18 14:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 16:38 bug#25917: operating-system file-system with (check? #t) but (needed-for-boot #f) pauses boot until user interaction Danny Milosavljevic
2017-03-11 11:21 ` Ludovic Courtès
2017-03-12 16:56 ` bug#25917: [PATCH] services: Don't check filesystem even if #:check? if not #:needed-for-boot Danny Milosavljevic
2017-03-13 9:01 ` Ludovic Courtès
2017-03-13 19:55 ` Danny Milosavljevic
2017-03-14 8:41 ` Ludovic Courtès
2017-03-14 19:18 ` Danny Milosavljevic
2017-03-14 20:18 ` Ludovic Courtès
2017-03-12 16:59 ` bug#25917: [PATCH v2] services: If a filesystem is not marked as needed for boot, don't check it even if told to check it Danny Milosavljevic
2017-03-16 17:40 ` bug#25917: [PATCH] file-systems: Factorize file-system-packages Danny Milosavljevic
2017-03-17 9:03 ` Ludovic Courtès
2017-03-17 12:19 ` Danny Milosavljevic
2017-03-18 11:00 ` Ludovic Courtès
2017-03-18 11:04 ` Ludovic Courtès
2017-03-18 9:42 ` Danny Milosavljevic
2017-03-18 14:06 ` Danny Milosavljevic [this message]
2017-03-19 15:44 ` bug#25917: [PATCH v2] services: file-system-shepherd-service: Make it find the fsck programs Ludovic Courtès
2017-04-22 23:34 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170318140632.1778-1-dannym@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=25917@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.