bug#24445: GNOME desktop session crash when re-arranging dock

[Thomas Danckaert <post@thomasdanckaert.be>]

[-- Attachment #1: Type: text/plain, Size: 1531 bytes --]

ludo@gnu.org (Ludovic Courtès) writes:

> I think that’d be OK.
>
> Though libXcursor contains a few ‘getenv’ calls, notably for
> XCURSOR_PATH, which looks like it’s what we’re looking for.
>
> I tested the attached path in a VM and it seems to fix the bug: I can
> drag a window in the overview area on the right and it no longer crashes
> (*and* I get a hand-shaped cursor when hovering that area :-)).  And we
> don’t need to modify libXcursor.
>
> (We could do slightly better by using the absolute file name of the
> actual icon theme instead of /run/current-system, but it’s complicated
> because I guess it doesn’t have to be Adwaita.)
>
> Thoughts?

Ha, I was just going to reply the same (see attached patch).  I've
tested it on my system as well, and it works.

Indeed encoding the absolute file name of the icon theme seems hard,
unless we set the icon theme inside the system configuration?  Not sure
how we want to handle icon themes installed in user profiles.

In my patch, I included both system and user profile, in case users want
to install icon themes in their profile, as well as the default ~/.icons
(which seems to be a kind of standard as well, so thought we could keep
it by default).

Also, I'm not sure if we need to set both paths in /etc/profile, or if
we can just have icon theme packages prepend to the current XCURSOR_PATH
when installed into a user profile (I'm not familiar with the details of
http://bugs.gnu.org/20255)?

cheers!

Thomas


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-system-operating-system-etc-service-Set-XCURSOR_PATH.patch --]
[-- Type: text/x-patch, Size: 1094 bytes --]

From e6328f95f3c7dbec3f124f15a3cd50f95e4431d2 Mon Sep 17 00:00:00 2001
From: Thomas Danckaert <thomas.danckaert@gmail.com>
Date: Sun, 8 Oct 2017 17:21:09 +0200
Subject: [PATCH] system: operating-system-etc-service: Set XCURSOR_PATH.

* gnu/system.scm (operating-system-etc-service): Set XCURSOR_PATH environment
  variable so that libxcursor finds cursors in user and system profiles.
---
 gnu/system.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/system.scm b/gnu/system.scm
index 8ab4801b7..6e9aa0635 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -579,6 +579,7 @@ export MANPATH=$HOME/.guix-profile/share/man:/run/current-system/profile/share/m
 export INFOPATH=$HOME/.guix-profile/share/info:/run/current-system/profile/share/info
 export XDG_DATA_DIRS=$HOME/.guix-profile/share:/run/current-system/profile/share
 export XDG_CONFIG_DIRS=$HOME/.guix-profile/etc/xdg:/run/current-system/profile/etc/xdg
+export XCURSOR_PATH=$HOME/.icons:$HOME/.guix-profile/share/icons:/run/current-system/profile/share/icons
 
 # Ignore the default value of 'PATH'.
 unset PATH
-- 
2.14.2