all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Thomas Danckaert <post@thomasdanckaert.be>
Cc: Mohammed Sadiq <sadiq@sadiqpk.org>, 24445@debbugs.gnu.org
Subject: bug#24445: GNOME desktop session crash when re-arranging dock
Date: Sun, 08 Oct 2017 17:08:58 +0200	[thread overview]
Message-ID: <871smdfzhx.fsf@gnu.org> (raw)
In-Reply-To: <87a811n3yc.fsf@thomasdanckaert.be> (Thomas Danckaert's message of "Sun, 08 Oct 2017 15:50:51 +0200")

[-- Attachment #1: Type: text/plain, Size: 1385 bytes --]

Hello!

Thomas Danckaert <post@thomasdanckaert.be> skribis:

> libxcursor's configure script has an option "--with-cursorpath=<paths>"
> to set a default search path for cursors.  If no option is given (as is
> the case with our package), the default is
> DEF_CURSORPATH="~/.icons:${datadir}/icons:${datadir}/pixmaps", which is
> exactly the set of directories in the strace (${HOME}/.icons and
> ${INSTALLPREFIX}/share/icons).
>
> So I guess that adding relevant directories to the libxcursor search
> path would solve the problem.  For Guix, it'd be useful to add
> /run/current-system/profile/share/icons, as well as
> ~/.guix-profile/share/icons (for users installing other icon themes in
> their profile).  Would this be ok?

I think that’d be OK.

Though libXcursor contains a few ‘getenv’ calls, notably for
XCURSOR_PATH, which looks like it’s what we’re looking for.

I tested the attached path in a VM and it seems to fix the bug: I can
drag a window in the overview area on the right and it no longer crashes
(*and* I get a hand-shaped cursor when hovering that area :-)).  And we
don’t need to modify libXcursor.

(We could do slightly better by using the absolute file name of the
actual icon theme instead of /run/current-system, but it’s complicated
because I guess it doesn’t have to be Adwaita.)

Thoughts?

Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 890 bytes --]

diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
index 527a3101c..4633f0fc6 100644
--- a/gnu/services/desktop.scm
+++ b/gnu/services/desktop.scm
@@ -791,7 +791,11 @@ accountsservice web site} for more information."
                                       gnome-package))
           (service-extension profile-service-type
                              (compose list
-                                      gnome-package))))))
+                                      gnome-package))
+          (service-extension session-environment-service-type
+                             (const
+                              '(("XCURSOR_PATH"
+                                 . "/run/current-system/profile/share/icons"))))))))
 
 (define* (gnome-desktop-service #:key (config (gnome-desktop-configuration)))
   "Return a service that adds the @code{gnome} package to the system profile,

  reply	other threads:[~2017-10-08 15:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15 13:45 bug#24445: GNOME desktop session crash when re-arranging dock Ravishankar S
2017-09-27  7:48 ` Thomas Danckaert
2017-09-30  5:51 ` bug#24445: [No Subject] Mohammed Sadiq
2017-10-02 14:51   ` bug#24445: GNOME desktop session crash when re-arranging dock Ludovic Courtès
2017-10-02 18:01     ` Mohammed Sadiq
2017-10-02 18:34     ` Mark H Weaver
2017-10-08 13:50       ` Thomas Danckaert
2017-10-08 15:08         ` Ludovic Courtès [this message]
2017-10-08 15:38           ` Thomas Danckaert
2017-10-08 19:18             ` Ludovic Courtès
2017-10-09  8:58               ` Thomas Danckaert
2017-10-09  9:51                 ` Ludovic Courtès
2017-10-09 10:47                   ` Thomas Danckaert
2017-10-10  8:29                   ` Thomas Danckaert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871smdfzhx.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=24445@debbugs.gnu.org \
    --cc=post@thomasdanckaert.be \
    --cc=sadiq@sadiqpk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.