all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Katherine Cox-Buday <cox.katherine.e@gmail.com>
To: 34752@debbugs.gnu.org
Subject: [bug#34752] Duplicated work (sorry!)
Date: Sat, 16 Mar 2019 17:57:29 -0500	[thread overview]
Message-ID: <87imwi2zs6.fsf@gmail.com> (raw)
In-Reply-To: <e1b11f5dfcc7ed9793464db2f98b79e3851546b8.1551738339.git.leo@famulari.name>

Hey Leo, I've just submitted patch 34887. I didn't realize your patch
existed until I had already submitted. I apologize, I don't contribute
to projects managed in this style enough to have the workflow
internalized :(

At any rate, my patch does much the same thing except that it leaves
1.11 in place as default. I did that for a couple of reasons:

- In organizations, it's very common for projects/teams to lag behind a
  bit the newest releases, and for people installing Go through Guix,
  it's nice to still have previous versions available. The Go team
  officially supports LATEST-2 releases, and I think we should consider
  doing the same.

- https://golang.org/doc/go1.12#gocache states that the build cache is
  now required. I saw that you were experimenting with setting the home
  directory to `/tmp`. The approach I considered taking was to modify
  the Go build-system to override the `GOCACHE` environmental variable
  when doing builds. Otherwise, any Go package will have to spoof the
  home directory.

Regarding your question about the test failures. I tried to resolve
these in 1.11 and the new ones that cropped up in 1.12. The issue is
that these "scripts" are effectively running in a custom little
script-engine that was custom built. I made some attempts at correcting
this which you can read about in patch 32768. You can find out more
about this scripting engine here:

https://github.com/golang/go/blob/release-branch.go1.12/src/cmd/go/testdata/script/README

-- 
Katherine

  reply	other threads:[~2019-03-16 23:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-04 22:28 [bug#34752] [PATCH] WIP: Update Go to 1.12 Leo Famulari
2019-03-16 22:57 ` Katherine Cox-Buday [this message]
2019-03-18 20:14   ` bug#34752: Duplicated work (sorry!) Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imwi2zs6.fsf@gmail.com \
    --to=cox.katherine.e@gmail.com \
    --cc=34752@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.