From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:56273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5ISl-0005Np-Rp for guix-patches@gnu.org; Sat, 16 Mar 2019 19:11:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5IFe-0005eK-5B for guix-patches@gnu.org; Sat, 16 Mar 2019 18:58:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33250) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h5IFd-0005dw-Sn for guix-patches@gnu.org; Sat, 16 Mar 2019 18:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h5IFd-0003cY-Lo for guix-patches@gnu.org; Sat, 16 Mar 2019 18:58:01 -0400 Subject: [bug#34752] Duplicated work (sorry!) References: In-Reply-To: Resent-Message-ID: From: Katherine Cox-Buday Date: Sat, 16 Mar 2019 17:57:29 -0500 Message-ID: <87imwi2zs6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 34752@debbugs.gnu.org Hey Leo, I've just submitted patch 34887. I didn't realize your patch existed until I had already submitted. I apologize, I don't contribute to projects managed in this style enough to have the workflow internalized :( At any rate, my patch does much the same thing except that it leaves 1.11 in place as default. I did that for a couple of reasons: - In organizations, it's very common for projects/teams to lag behind a bit the newest releases, and for people installing Go through Guix, it's nice to still have previous versions available. The Go team officially supports LATEST-2 releases, and I think we should consider doing the same. - https://golang.org/doc/go1.12#gocache states that the build cache is now required. I saw that you were experimenting with setting the home directory to `/tmp`. The approach I considered taking was to modify the Go build-system to override the `GOCACHE` environmental variable when doing builds. Otherwise, any Go package will have to spoof the home directory. Regarding your question about the test failures. I tried to resolve these in 1.11 and the new ones that cropped up in 1.12. The issue is that these "scripts" are effectively running in a custom little script-engine that was custom built. I made some attempts at correcting this which you can read about in patch 32768. You can find out more about this scripting engine here: https://github.com/golang/go/blob/release-branch.go1.12/src/cmd/go/testdata/script/README -- Katherine