From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Elais Player <elais@fastmail.com>
Cc: 40947@debbugs.gnu.org
Subject: [bug#40947] Add emacs-boon
Date: Wed, 29 Apr 2020 16:48:02 +0200 [thread overview]
Message-ID: <87imhie4bh.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CSKI9Q.P7JNA1CYLV2D3@fastmail.com> (Elais Player's message of "Tue, 28 Apr 2020 13:57:48 -0600")
Hello,
Elais Player <elais@fastmail.com> writes:
> This patch adds the boon modal editing package
Thank you.
> Subject: [PATCH 1/1] Add emacs-boon package
>
> This patch adds boon modal editing packages.
The expected commit message is slightly different.
gnu: Add emacs-boon.
* gnu/packages/emacs-xyz.scm (emacs-boon): New variable.
If you use Yasnippets, using "add <TAB>" in an empty commit message
generates it for you. See (info "(guix)The Perfect Setup").
> provides a simple but convenient user interface to manage those trashed
> files.")
> (license license:gpl3+)))
As a rule of thumb, please do not append new packages at the end of the
file. It is more likely to generate merge conflicts.
> + (sha256
> + (base32
> + "1ss9bjs34q41pa0g0nbdzd8fwpjcbd2239rdlx5aykfv9v0b8j77"))))
Nitpick: could you move the string on the same line as `base32'?
> + (build-system emacs-build-system)
> + (propagated-inputs
> + `(("emacs-expand-region" ,emacs-expand-region)
> + ("spaceline" ,emacs-spaceline)
> + ("powerline" ,emacs-powerline)
> + ("emacs-dash" ,emacs-dash)
> + ("emacs-multiple-cursors" ,emacs-multiple-cursors)))
Could you re-order inputs alphabetically?
> + (home-page "https://github.com/jyp/boon")
> + (synopsis "Ergonomic Command Mode for Emacs.")
Synopsis is not expected to end with a full stop. You may want to run
guix lint on the package.
> + (description
> + "Boon brings modal editing capabilities to Emacs and...
> +
> +- It tries to be as ergonomic as possible.
> +- It remains lightweight (~300 loc for its core.)
> +- It attempts to integrate with Emacs as smoothly as possible")
Here you should write Texinfo markup:
@itemize
@item it tries to...
@item ...
...
@end itemize
However, you way want to extract the description from the project's
GitHub front page instead of the main file.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2020-04-29 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 19:57 [bug#40947] Add emacs-boon Elais Player
2020-04-29 14:48 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imhie4bh.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=40947@debbugs.gnu.org \
--cc=elais@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.