From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iFBpE46UqV6AKgAA0tVLHw (envelope-from ) for ; Wed, 29 Apr 2020 14:51:58 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id IDhhKJaUqV7pRgAA1q6Kng (envelope-from ) for ; Wed, 29 Apr 2020 14:52:06 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 100B7941C9A for ; Wed, 29 Apr 2020 14:49:17 +0000 (UTC) Received: from localhost ([::1]:50772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTo1T-00056X-Bk for larch@yhetil.org; Wed, 29 Apr 2020 10:49:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51138) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTo1I-00053l-PI for guix-patches@gnu.org; Wed, 29 Apr 2020 10:49:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTo1G-0003q0-WC for guix-patches@gnu.org; Wed, 29 Apr 2020 10:49:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60917) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTo1G-0003pv-Ji for guix-patches@gnu.org; Wed, 29 Apr 2020 10:49:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jTo1G-0008IR-GF for guix-patches@gnu.org; Wed, 29 Apr 2020 10:49:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40947] Add emacs-boon Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 29 Apr 2020 14:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40947 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Elais Player Cc: 40947@debbugs.gnu.org Received: via spool by 40947-submit@debbugs.gnu.org id=B40947.158817169531837 (code B ref 40947); Wed, 29 Apr 2020 14:49:02 +0000 Received: (at 40947) by debbugs.gnu.org; 29 Apr 2020 14:48:15 +0000 Received: from localhost ([127.0.0.1]:44230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTo0V-0008HR-An for submit@debbugs.gnu.org; Wed, 29 Apr 2020 10:48:15 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:34801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTo0Q-0008H8-5i for 40947@debbugs.gnu.org; Wed, 29 Apr 2020 10:48:13 -0400 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 1DF67200016; Wed, 29 Apr 2020 14:48:02 +0000 (UTC) From: Nicolas Goaziou References: Date: Wed, 29 Apr 2020 16:48:02 +0200 In-Reply-To: (Elais Player's message of "Tue, 28 Apr 2020 13:57:48 -0600") Message-ID: <87imhie4bh.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [-1.01 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49335891970563]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.18), country: US(-0.00), ip: 2001:470:142::17(-0.49)]; DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; MAILLIST(-0.20)[mailman]; FREEMAIL_TO(0.00)[fastmail.com]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[mail@nicolasgoaziou.fr,guix-patches-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; URIBL_BLOCKED(0.00)[fastmail.com:email]; MIME_GOOD(-0.10)[text/plain]; R_DKIM_NA(0.00)[]; DMARC_NA(0.00)[nicolasgoaziou.fr]; HAS_LIST_UNSUB(-0.01)[]; DNSWL_BLOCKED(0.00)[2001:470:142::17:from]; RCVD_COUNT_SEVEN(0.00)[9]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: PY+i04pAzroC Hello, Elais Player writes: > This patch adds the boon modal editing package Thank you. > Subject: [PATCH 1/1] Add emacs-boon package > > This patch adds boon modal editing packages. The expected commit message is slightly different. gnu: Add emacs-boon. * gnu/packages/emacs-xyz.scm (emacs-boon): New variable. If you use Yasnippets, using "add " in an empty commit message generates it for you. See (info "(guix)The Perfect Setup"). > provides a simple but convenient user interface to manage those trashed > files.") > (license license:gpl3+))) As a rule of thumb, please do not append new packages at the end of the file. It is more likely to generate merge conflicts. > + (sha256 > + (base32 > + "1ss9bjs34q41pa0g0nbdzd8fwpjcbd2239rdlx5aykfv9v0b8j77")))) Nitpick: could you move the string on the same line as `base32'? > + (build-system emacs-build-system) > + (propagated-inputs > + `(("emacs-expand-region" ,emacs-expand-region) > + ("spaceline" ,emacs-spaceline) > + ("powerline" ,emacs-powerline) > + ("emacs-dash" ,emacs-dash) > + ("emacs-multiple-cursors" ,emacs-multiple-cursors))) Could you re-order inputs alphabetically? > + (home-page "https://github.com/jyp/boon") > + (synopsis "Ergonomic Command Mode for Emacs.") Synopsis is not expected to end with a full stop. You may want to run guix lint on the package. > + (description > + "Boon brings modal editing capabilities to Emacs and... > + > +- It tries to be as ergonomic as possible. > +- It remains lightweight (~300 loc for its core.) > +- It attempts to integrate with Emacs as smoothly as possible") Here you should write Texinfo markup: @itemize @item it tries to... @item ... ... @end itemize However, you way want to extract the description from the project's GitHub front page instead of the main file. Could you send an updated patch? Regards, -- Nicolas Goaziou