From: "Ludovic Courtès" <ludo@gnu.org>
To: Carl Dong <contact@carldong.me>
Cc: 48726@debbugs.gnu.org
Subject: [bug#48726] [PATCH] gnu: nsis: Respect SOURCE-DATE-EPOCH for reproducibility
Date: Tue, 01 Jun 2021 23:19:23 +0200 [thread overview]
Message-ID: <87im2xz3j8.fsf@gnu.org> (raw)
In-Reply-To: <20210529053107.381628-1-contact@carldong.me> (Carl Dong's message of "Sat, 29 May 2021 01:31:07 -0400")
Hi,
Carl Dong <contact@carldong.me> skribis:
> * gnu/packages/patches/nsis-SConstruct-sde-support.patch: New patch.
> * gnu/packages/installers.scm (make-nsis)[source]: Apply it.
Nice! Minor issues:
> gnu/packages/installers.scm | 3 ++-
> .../patches/nsis-SConstruct-sde-support.patch | 15 +++++++++++++++
How about ‘nsis-source-date-epoch.patch’? It might be slightly clearer
in my view.
Please make sure to add it to ‘gnu/local.mk’.
> diff --git a/gnu/packages/patches/nsis-SConstruct-sde-support.patch b/gnu/packages/patches/nsis-SConstruct-sde-support.patch
> new file mode 100644
> index 0000000000..5edf1b7c8e
> --- /dev/null
> +++ b/gnu/packages/patches/nsis-SConstruct-sde-support.patch
Please add a line at the top saying what it does and linking to the
upstream issue (or ‘guix lint’ will complain, which would be so bad :-)).
OK to push with these changes, thank you!
Ludo’.
next prev parent reply other threads:[~2021-06-01 21:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-29 5:31 [bug#48726] [PATCH] gnu: nsis: Respect SOURCE-DATE-EPOCH for reproducibility Carl Dong
2021-05-29 8:59 ` Maxime Devos
2021-05-30 18:54 ` Carl Dong
2021-06-01 21:19 ` Ludovic Courtès [this message]
2021-06-03 19:46 ` [bug#48726] [PATCH v2] " Carl Dong
2021-06-04 15:39 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im2xz3j8.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=48726@debbugs.gnu.org \
--cc=contact@carldong.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.