From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UBp8MouktmCIHgEAgWs5BA (envelope-from ) for ; Tue, 01 Jun 2021 23:20:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6A/kLYuktmAJIQAAB5/wlQ (envelope-from ) for ; Tue, 01 Jun 2021 21:20:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4568522D4A for ; Tue, 1 Jun 2021 23:20:11 +0200 (CEST) Received: from localhost ([::1]:41968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loBo2-0005vO-0H for larch@yhetil.org; Tue, 01 Jun 2021 17:20:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loBnv-0005v6-JD for guix-patches@gnu.org; Tue, 01 Jun 2021 17:20:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54738) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loBnt-0002mn-UT for guix-patches@gnu.org; Tue, 01 Jun 2021 17:20:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1loBnt-0002EW-QX for guix-patches@gnu.org; Tue, 01 Jun 2021 17:20:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48726] [PATCH] gnu: nsis: Respect SOURCE-DATE-EPOCH for reproducibility Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 01 Jun 2021 21:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48726 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Carl Dong Cc: 48726@debbugs.gnu.org Received: via spool by 48726-submit@debbugs.gnu.org id=B48726.16225823738540 (code B ref 48726); Tue, 01 Jun 2021 21:20:01 +0000 Received: (at 48726) by debbugs.gnu.org; 1 Jun 2021 21:19:33 +0000 Received: from localhost ([127.0.0.1]:38051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loBnR-0002Dg-DH for submit@debbugs.gnu.org; Tue, 01 Jun 2021 17:19:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loBnP-0002DT-Fg for 48726@debbugs.gnu.org; Tue, 01 Jun 2021 17:19:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47528) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loBnK-0002Sm-84; Tue, 01 Jun 2021 17:19:26 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=57882 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loBnJ-0004GW-W8; Tue, 01 Jun 2021 17:19:26 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210529053107.381628-1-contact@carldong.me> Date: Tue, 01 Jun 2021 23:19:23 +0200 In-Reply-To: <20210529053107.381628-1-contact@carldong.me> (Carl Dong's message of "Sat, 29 May 2021 01:31:07 -0400") Message-ID: <87im2xz3j8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1622582411; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=zNwVvSJ4BcpZsY77LxemszCgxz7nAM8JJPPIVSXGBmo=; b=I8zik4wQvilhlPRuLPjRGLCFoRSqmB0wHRcVtrtYCqm5B/iFO4O3dr7AFoRDwNGpvTooRE bx1AAYcsN5s55k0DPoC2jWPYYETOsm3oOcyhYpBrZGU+wP2n37Qlflp/BnkD5xU2I5NrvP w8/sye9sQQ3l2HCubOWGDfcdz3K++a24eTnYYYwZSeuRWMEZz6zXTKzg7gONhDcZ4doHxe SXsB48WclvZ8vSnyprwzriBWPJNPyRQqi6WqaUazJ2qgsG7mHYgaMUYcfSviuwiPRSab5n orpj8ElkiFXHk5E4OMR66SsEvespW+/d8akjsyp8Wky79270hyQoVfiX7Np5kQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1622582411; a=rsa-sha256; cv=none; b=dvRZFyae3UGGZtM8oqo/Ux2c90ty/bg1oRq4IJ+GzCDTC1tah4PB9eYGnAtff0NVvDQVK1 yUxPlNVnIazRh8EUUF7zauHhNpukWCbduznz8uFg/TbhmxWcwmasfd/52SK2IAE5F7oxSO CwvIzDx5aMqXwxBPhoF66gDmFuPHsXx7WREuswSmqZnahWrNOtGZRk4xdwZP/dgMLfUf+M JJRvGvvzZ7f8T+3MMgJkgiasMTeLEbqv5mljhJMDA84YNCUvCFXjAOFi8katHgXthLkEvh OfTjvAiVIJryceG5iDxeL3Nfwk6v3HcMpNmnm58bKFiSp8haAemRTOPSgfy41Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.93 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 4568522D4A X-Spam-Score: -2.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: voqLNdVw2wAF Hi, Carl Dong skribis: > * gnu/packages/patches/nsis-SConstruct-sde-support.patch: New patch. > * gnu/packages/installers.scm (make-nsis)[source]: Apply it. Nice! Minor issues: > gnu/packages/installers.scm | 3 ++- > .../patches/nsis-SConstruct-sde-support.patch | 15 +++++++++++++++ How about =E2=80=98nsis-source-date-epoch.patch=E2=80=99? It might be slig= htly clearer in my view. Please make sure to add it to =E2=80=98gnu/local.mk=E2=80=99. > diff --git a/gnu/packages/patches/nsis-SConstruct-sde-support.patch b/gnu= /packages/patches/nsis-SConstruct-sde-support.patch > new file mode 100644 > index 0000000000..5edf1b7c8e > --- /dev/null > +++ b/gnu/packages/patches/nsis-SConstruct-sde-support.patch Please add a line at the top saying what it does and linking to the upstream issue (or =E2=80=98guix lint=E2=80=99 will complain, which would b= e so bad :-)). OK to push with these changes, thank you! Ludo=E2=80=99.