From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Brice Waegeneire <brice@waegenei.re>
Cc: 53431@debbugs.gnu.org
Subject: [bug#53431] [PATCH 0/3] gnu: ddcutil: Update to 1.2.1.
Date: Fri, 21 Jan 2022 22:38:35 -0500 [thread overview]
Message-ID: <87iluc8mo4.fsf_-_@gmail.com> (raw)
In-Reply-To: <20220121232306.12976-1-brice@waegenei.re> (Brice Waegeneire's message of "Sat, 22 Jan 2022 00:23:06 +0100")
Hello Brice!
Brice Waegeneire <brice@waegenei.re> writes:
> * gnu/packages/linux.scm (i2c-tools): Update to 4.3.
> [arguments]: Up case "prefix" make-flag and add "LDFLAGS".
^ the ^ make flag
[...]
> @@ -4430,21 +4430,22 @@ (define-public iucode-tool
> (define-public i2c-tools
> (package
> (name "i2c-tools")
> - (version "3.1.1")
> + (version "4.3")
> (source (origin
> (method url-fetch)
> (uri (string-append
> "http://jdelvare.nerim.net/mirror/i2c-tools/i2c-tools-"
> - version ".tar.bz2"))
> + version ".tar.xz"))
> (sha256
> (base32
> - "000pvg995qy1b15ks59gd0klri55hb33kqpg5czy84hw1pbdgm0l"))))
> + "1y0fphjd5ah2j886x8i175r7viq0hmx666hyca0wi4dzrm290qxk"))))
> (build-system gnu-build-system)
> (arguments
> `(#:tests? #f ; no 'check' target
> #:make-flags
> - ,#~(list (string-append "prefix=" #$output)
> - (string-append "CC=" #$(cc-for-target)))
> + ,#~(list (string-append "PREFIX=" #$output)
> + (string-append "CC=" #$(cc-for-target))
> + (string-append "LDFLAGS=-Wl,-rpath=" #$output "/lib"))
Why is this ld directive needed? They don't use it in Nix, for
instance. A comment would be helpful.
> ;; No configure script.
> #:phases (modify-phases %standard-phases (delete 'configure))))
> (inputs
> @@ -4458,6 +4459,26 @@ (define-public i2c-tools
> SMBus access.")
> (license license:gpl2+)))
Looking at the Nix package definition, they do some other things that we
don't have, which we perhaps should:
--8<---------------cut here---------------start------------->8---
postPatch = ''
substituteInPlace eeprom/decode-edid \
--replace "/usr/sbin/parse-edid" "${read-edid}/bin/parse-edid"
substituteInPlace stub/i2c-stub-from-dump \
--replace "/sbin/" ""
;--8<---------------cut here---------------end--------------->8---
They patch a reference to parse-edid and strip the '/sbin/' prefix from
some other place.
> +;; Needed for novena-eeprom
^. (ending period)
> +(define-public i2c-tools-3
> + (package
> + (inherit i2c-tools)
> + (version "3.1.1")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://jdelvare.nerim.net/mirror/i2c-tools/i2c-tools-"
> + version ".tar.bz2"))
> + (sha256
> + (base32
> + "000pvg995qy1b15ks59gd0klri55hb33kqpg5czy84hw1pbdgm0l"))))
> + (arguments
> + `(#:make-flags
> + ,#~(list (string-append "prefix=" #$output)
> + (string-append "CC=" #$(cc-for-target)))
> + ,@(strip-keyword-arguments '(#:make-flags)
> + (package-arguments i2c-tools))))))
> +
> (define-public xsensors
> (package
> (name "xsensors")
The rest LGTM!
Thanks,
Maxim
next prev parent reply other threads:[~2022-01-22 3:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 23:13 [bug#53431] [PATCH 0/3] gnu: ddcutil: Update to 1.2.1 Brice Waegeneire
2022-01-21 23:23 ` [bug#53431] [PATCH 1/3] gnu: i2c-tools: Update to 4.3 Brice Waegeneire
2022-01-22 3:38 ` Maxim Cournoyer [this message]
2022-03-06 21:42 ` [bug#53431] [PATCH 0/3] gnu: ddcutil: Update to 1.2.1 Ludovic Courtès
2022-09-28 19:26 ` bug#53431: " Maxim Cournoyer
2022-01-23 2:35 ` [bug#53431] " Maxim Cournoyer
2022-02-12 9:17 ` [bug#53431] [PATCH 3/3] gnu: ddcui: Update to 0.2.0 Brice Waegeneire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iluc8mo4.fsf_-_@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=53431@debbugs.gnu.org \
--cc=brice@waegenei.re \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.