From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aBmiNl5862EkIAEAgWs5BA (envelope-from ) for ; Sat, 22 Jan 2022 04:39:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id QItLL15862FeAwAAG6o9tA (envelope-from ) for ; Sat, 22 Jan 2022 04:39:10 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 36082DACF for ; Sat, 22 Jan 2022 04:39:10 +0100 (CET) Received: from localhost ([::1]:50448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nB7F7-0006ON-Bt for larch@yhetil.org; Fri, 21 Jan 2022 22:39:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nB7F0-0006NH-Jm for guix-patches@gnu.org; Fri, 21 Jan 2022 22:39:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42570) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nB7F0-0000tt-Ay for guix-patches@gnu.org; Fri, 21 Jan 2022 22:39:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nB7F0-0000Yb-6w for guix-patches@gnu.org; Fri, 21 Jan 2022 22:39:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53431] [PATCH 0/3] gnu: ddcutil: Update to 1.2.1. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 22 Jan 2022 03:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53431 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brice Waegeneire Cc: 53431@debbugs.gnu.org Received: via spool by 53431-submit@debbugs.gnu.org id=B53431.16428227272115 (code B ref 53431); Sat, 22 Jan 2022 03:39:02 +0000 Received: (at 53431) by debbugs.gnu.org; 22 Jan 2022 03:38:47 +0000 Received: from localhost ([127.0.0.1]:35473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nB7El-0000Y2-EL for submit@debbugs.gnu.org; Fri, 21 Jan 2022 22:38:47 -0500 Received: from mail-qv1-f51.google.com ([209.85.219.51]:36814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nB7Ei-0000Xn-0o for 53431@debbugs.gnu.org; Fri, 21 Jan 2022 22:38:45 -0500 Received: by mail-qv1-f51.google.com with SMTP id g11so6796163qvu.3 for <53431@debbugs.gnu.org>; Fri, 21 Jan 2022 19:38:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=7HwHLZNPdCyjdiSYpjszc1BQSwp9MuSwkE1ohDMEW4E=; b=OpyhUv9fgni8H7IeGpTw+HuMHESac0BovYa4Mu3oGcKGSJlnxg6ick02BmJgXwiUrh g7Cc/h4bWiPTx6pyUEQrc1M/zHjczQ1Qri8FncVwmguxn1qEY/j/KPXUk8v4wnKDlAig cF/VL5xtA1fh7twVY3y74Tj17usZpiOz+raxAZ5GA1p+zi5edDUDTtaiEMti776NPYjZ uwSC1FmsZOTqETPp/grFpDmXL+jWdL6EFMjuR4t3X3h5Iv3sb4YqRSf0fuWQ9RgaRj97 BjVvMIx32OMRkkfm8CzNAFzSOhtuwZFd8v6U6B6pCyvuZBJ1gHqeAcjw5CDRTgsY11Ar UqdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=7HwHLZNPdCyjdiSYpjszc1BQSwp9MuSwkE1ohDMEW4E=; b=BrUued05RROpfh7aBZr1Elajx581xGxnfwLuVj/sEnV+Wce3VIMDe8tMQfXHbcKTe2 C5HroO/bB79OTNLeSKY5d1jjz4Wpb0utqBQXtEmaVdtkJZZvkPqA4fAqV98fNCU4aUIb L88Afw56lJxl0LfVw4MOQVAQ1JsrnXUgqtTtKfCFfTkw3OMDgFWnfLwcc+pIYn3/vE7Z XcKwqz9hoGKV/U03ek7TfqZpMfIFFW2CZMBFbQpgNdM8DwXkD6QtG/FTcSwmcenB/LEO VTDY5jmbmn768eNivrqH9Ui1F208Y8fcaUZQSu+lAZwaTMOaYMLz7/9YRcQZwVsMIbtj DZ8Q== X-Gm-Message-State: AOAM5337ighq+V4R5nOiPOTFaKu7Fh+Tm4MDDRuU5PmiWhk0flbFQBDe UzvrJkqcbbbEQBqLgK79AwTQ6rssqJU= X-Google-Smtp-Source: ABdhPJw5l0nYG2eQiOJHsggs4l47OyM/Vevgdc30C66mj1XjfxcP42jDbFlVdFESXTdBGtQdZFdJZA== X-Received: by 2002:ad4:5ca5:: with SMTP id q5mr6530000qvh.128.1642822717198; Fri, 21 Jan 2022 19:38:37 -0800 (PST) Received: from hurd (dsl-205-236-230-254.b2b2c.ca. [205.236.230.254]) by smtp.gmail.com with ESMTPSA id x12sm4110539qta.79.2022.01.21.19.38.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 19:38:36 -0800 (PST) From: Maxim Cournoyer References: <20220121231316.8253-1-brice@waegenei.re> <20220121232306.12976-1-brice@waegenei.re> Date: Fri, 21 Jan 2022 22:38:35 -0500 In-Reply-To: <20220121232306.12976-1-brice@waegenei.re> (Brice Waegeneire's message of "Sat, 22 Jan 2022 00:23:06 +0100") Message-ID: <87iluc8mo4.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642822750; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=7HwHLZNPdCyjdiSYpjszc1BQSwp9MuSwkE1ohDMEW4E=; b=EngJDcgdYTKFm93VuefXrqbAUeEXfUtYKqTn8+76a3RPt1RrJrTRtROtaub2kTngu0XaxJ ncBkyAzNl4eqWwgQ6sT6gWPQO1y4B+46g6uSqft7/5ORpjVfzW5Rpab/ih9LF0k0jq6Rer rRPLzYhr2dr9geHc5yvIg0Euy4xQbUGx2uFqx6j60W8nnRpNzNhLzcGzax1nuOA4I6hcXg tWVWs7tGd5mlIWAebKVHMmL0nopNeq/jAc3H+WlovU3UHbIdSyMNFpU8WOOL5lgkhm0G8X SCvEuZYI5+iHg+LHz+LoZeRRXSpJ78ZKsL/IWwoDR949WexCkB8IlDtvfDpCXw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642822750; a=rsa-sha256; cv=none; b=GCcZLoka12w7RZ0F19MCs2vuavm9QCmHyeXCHPa0Z4X7YMvdrKrCUocKVtTGUIIe5ixWx7 kc7A4ZTIyIqg/eR4ajAtGvGDYaWHhpLmaWXBHpAHmKKvoJP9hzNIldfulfVb/ERZOI5mXh UTrjKv/xmp+UnQYWkxPYYVNI43tfID9ogsoVJVcXLTedz3YyTJvmZfTYHLezZo2zTiPcWI Hd9efjLW+A+r+8dv54z5WcVZ2gscAZKJZz6mzY9ml04JKAEl691W2hJQlVC8DKoTZeJZYO hNuE1h/czn40qD8VWuKTG0etxk1Ob+Wx2wX1kHoGMChUYARaxSLB0iHYKpCnqg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=OpyhUv9f; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.03 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=OpyhUv9f; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 36082DACF X-Spam-Score: -2.03 X-Migadu-Scanner: scn0.migadu.com X-TUID: PUrEy9VyYYj/ Hello Brice! Brice Waegeneire writes: > * gnu/packages/linux.scm (i2c-tools): Update to 4.3. > [arguments]: Up case "prefix" make-flag and add "LDFLAGS". ^ the ^ make flag [...] > @@ -4430,21 +4430,22 @@ (define-public iucode-tool > (define-public i2c-tools > (package > (name "i2c-tools") > - (version "3.1.1") > + (version "4.3") > (source (origin > (method url-fetch) > (uri (string-append > "http://jdelvare.nerim.net/mirror/i2c-tools/i2c-tools-" > - version ".tar.bz2")) > + version ".tar.xz")) > (sha256 > (base32 > - "000pvg995qy1b15ks59gd0klri55hb33kqpg5czy84hw1pbdgm0l")))) > + "1y0fphjd5ah2j886x8i175r7viq0hmx666hyca0wi4dzrm290qxk")))) > (build-system gnu-build-system) > (arguments > `(#:tests? #f ; no 'check' target > #:make-flags > - ,#~(list (string-append "prefix=" #$output) > - (string-append "CC=" #$(cc-for-target))) > + ,#~(list (string-append "PREFIX=" #$output) > + (string-append "CC=" #$(cc-for-target)) > + (string-append "LDFLAGS=-Wl,-rpath=" #$output "/lib")) Why is this ld directive needed? They don't use it in Nix, for instance. A comment would be helpful. > ;; No configure script. > #:phases (modify-phases %standard-phases (delete 'configure)))) > (inputs > @@ -4458,6 +4459,26 @@ (define-public i2c-tools > SMBus access.") > (license license:gpl2+))) Looking at the Nix package definition, they do some other things that we don't have, which we perhaps should: --8<---------------cut here---------------start------------->8--- postPatch = '' substituteInPlace eeprom/decode-edid \ --replace "/usr/sbin/parse-edid" "${read-edid}/bin/parse-edid" substituteInPlace stub/i2c-stub-from-dump \ --replace "/sbin/" "" ;--8<---------------cut here---------------end--------------->8--- They patch a reference to parse-edid and strip the '/sbin/' prefix from some other place. > +;; Needed for novena-eeprom ^. (ending period) > +(define-public i2c-tools-3 > + (package > + (inherit i2c-tools) > + (version "3.1.1") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "http://jdelvare.nerim.net/mirror/i2c-tools/i2c-tools-" > + version ".tar.bz2")) > + (sha256 > + (base32 > + "000pvg995qy1b15ks59gd0klri55hb33kqpg5czy84hw1pbdgm0l")))) > + (arguments > + `(#:make-flags > + ,#~(list (string-append "prefix=" #$output) > + (string-append "CC=" #$(cc-for-target))) > + ,@(strip-keyword-arguments '(#:make-flags) > + (package-arguments i2c-tools)))))) > + > (define-public xsensors > (package > (name "xsensors") The rest LGTM! Thanks, Maxim