all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Josselin Poiret via Guix-patches via <guix-patches@gnu.org>
To: Z572 <873216071@qq.com>, 63839@debbugs.gnu.org
Subject: [bug#63839] [PATCH] gnu: riscv-pk: don't target riscv64-linux-gnu when current system is riscv64.
Date: Tue, 06 Jun 2023 17:48:40 +0200	[thread overview]
Message-ID: <87ilc08ucn.fsf@jpoiret.xyz> (raw)
In-Reply-To: <tencent_D0FFDA97CD8454B0ACE9BF6F9DB7F29E1207@qq.com>

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

Hi,

Z572 via Guix-patches via <guix-patches@gnu.org> writes:


> +      ;; riscv-pk can only be built for riscv64.
> +      (if (string-prefix? "riscv64" (%current-system))
> +          '()
> +          (list
> +           #:target "riscv64-linux-gnu"))

I don't think that's a good idea, in general, consumers of the package
should be the ones specifying for which arch this package builds.  For
that purpose, there's the supported-systems field of the package record
type.  It's not good in general to hardcode targets in package
definitions.

Best,
-- 
Josselin Poiret

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 682 bytes --]

  reply	other threads:[~2023-06-06 16:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-02 12:10 [bug#63839] [PATCH] gnu: riscv-pk: don't target riscv64-linux-gnu when current system is riscv64 Z572 via Guix-patches via
2023-06-06 15:48 ` Josselin Poiret via Guix-patches via [this message]
2023-06-11 14:48   ` Z572 via Guix-patches via
2023-06-11 14:48     ` Z572 via Guix-patches via
2023-08-25 13:11       ` Josselin Poiret via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilc08ucn.fsf@jpoiret.xyz \
    --to=guix-patches@gnu.org \
    --cc=63839@debbugs.gnu.org \
    --cc=873216071@qq.com \
    --cc=dev@jpoiret.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.