From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id RAUTL5Bdf2RqxQAASxT56A (envelope-from ) for ; Tue, 06 Jun 2023 18:23:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id uBhMLpBdf2RJGgAAauVa8A (envelope-from ) for ; Tue, 06 Jun 2023 18:23:44 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6C60D3B1DB for ; Tue, 6 Jun 2023 18:23:44 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6Yvh-0006XZ-GJ; Tue, 06 Jun 2023 11:49:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6Yve-0006Ww-Qk for guix-patches@gnu.org; Tue, 06 Jun 2023 11:49:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q6Yve-0002vu-Hp for guix-patches@gnu.org; Tue, 06 Jun 2023 11:49:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q6Yvd-00055B-Vy for guix-patches@gnu.org; Tue, 06 Jun 2023 11:49:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63839] [PATCH] gnu: riscv-pk: don't target riscv64-linux-gnu when current system is riscv64. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 06 Jun 2023 15:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63839 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Z572 <873216071@qq.com>, 63839@debbugs.gnu.org Received: via spool by 63839-submit@debbugs.gnu.org id=B63839.168606653219522 (code B ref 63839); Tue, 06 Jun 2023 15:49:01 +0000 Received: (at 63839) by debbugs.gnu.org; 6 Jun 2023 15:48:52 +0000 Received: from localhost ([127.0.0.1]:52851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6YvT-00054n-UV for submit@debbugs.gnu.org; Tue, 06 Jun 2023 11:48:52 -0400 Received: from jpoiret.xyz ([206.189.101.64]:44926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6YvN-00054b-UZ for 63839@debbugs.gnu.org; Tue, 06 Jun 2023 11:48:49 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 37EF5184F2D; Tue, 6 Jun 2023 15:48:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1686066524; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6l2lt8mS98CpruOzj6yYufbnO/kkN9zvs8PndynXiuI=; b=c47D4GC5Ely8d3/WzpB03VVlPn3f2yZxtvvjOxrUioOPyxX06HRAil/ikubYSRs4dqDbvW pdRauDi+lp8TxsN8qj8Z0giFWD9kIBwZ9uPL2Y4HI0LkEfZTMLwtYkPtYxllsYqfUsOw0L WKFs/HjwkESgHc5AM9QgzYCSBcPBDyD3n8cJLy6rPvUDxrfd1b9hfK0/D1JLp9KVQydjy1 gfln6spm56G8e40Xjqh7h+arU2tWlrx736+Cgfxczl+PMT4cpwjWuRnEsmMgcq2A0Iu8KM /pkTrj6mnWunX6sI8AypmHyzspIfL1Ex6wm3FYNuMCFBdBizoShPBFdvXSfYFQ== In-Reply-To: References: Date: Tue, 06 Jun 2023 17:48:40 +0200 Message-ID: <87ilc08ucn.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Josselin Poiret X-ACL-Warn: , Josselin Poiret via Guix-patches From: Josselin Poiret via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1686068624; a=rsa-sha256; cv=none; b=pnQp31veOKafZqHm96l6ZoB6IcW76yiex/ZAvUBWmy1uk/a9gjS5w8MN806yTjQ41PF1bW K5kJoWg6oPDj2AshcYHmspwwZkx3IE47YrKZMImbW56qZM18L2d9Ws8R662G44kdjqq5aK 2C9+0zuQnZkZE0DukMDmpCRwcONl16QZYga+CtQIKMU1S2qjB/mw+feJQvyefwfH39Q7+w lvfen91UeZDsvVsIKfqsZL6IdWz5ySI0iUBLPZZGkE20KAcpg2J20WgJMt0HLpgr3qCQkt 8kvZQK9yBPdrv4wZzdbJn9w/2TPbtK8fsvmGr0D77KoYN55RniSoZ527ttSEiA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=c47D4GC5; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1686068624; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=6l2lt8mS98CpruOzj6yYufbnO/kkN9zvs8PndynXiuI=; b=JMHiYA34Rp3zGH0wn/XT6wqYQMo4JCyfIUJ253cVhIwKFCWyOYNan33t4lSuy28/+PyFgl e8Tv86mIaDSyTKhdRrDVPIeNk5zC5O0BzOFepHA3qL5PcJR91CKP0ol4hf6qaV30tsPDWW ZITTJSqhp/efeS2XnOVhD/t4b8j//N92AKCppwhWLYysX23mthl1wzvMz1uM4tR+72MA6E /+ucD+kZdR7wuBEUxgcpGy6w1V/eRUvfiJcNls6XO3HqH1+boYj+BDfQJRf76jurBJVTJp clrxuNIrxgXCqe4SigHDokZjLh8fHjTj8IEUr1rqT57CIPP6XGxBYsiO26mb2w== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=c47D4GC5; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -6.39 X-Spam-Score: -6.39 X-Migadu-Queue-Id: 6C60D3B1DB X-TUID: 0cw3vGA2WxJD --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Z572 via Guix-patches via writes: > + ;; riscv-pk can only be built for riscv64. > + (if (string-prefix? "riscv64" (%current-system)) > + '() > + (list > + #:target "riscv64-linux-gnu")) I don't think that's a good idea, in general, consumers of the package should be the ones specifying for which arch this package builds. For that purpose, there's the supported-systems field of the package record type. It's not good in general to hardcode targets in package definitions. Best, =2D-=20 Josselin Poiret --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHEBAEBCgAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmR/VVgQHGRldkBqcG9p cmV0Lnh5egAKCRBQXkC5FhcaihBoC/98OZmmPkD0dHy5lKQPDcIUPv+u7GAsejos 42KetAPPye6vmQp/oUNiSq4n2VN49zto4SlLlIFPfV41CmYz2Tj/K7DPOIQznD6Z 6ft8nMlxP0qQoveQqJxnuXTseZVeIFpu/0gnqJjI2eNwhNceA3GfASJ9Fs8lOmel KuSHh4o/KauDHDUHVIrYPnCTic0ECGZdlRvKFPVGYXtzwd5KNGWOnVSBbOB6P6L0 dCGe5G9D7687rxZFrPmdQ4QoZxyN2rOUBxlBkOyfFYwQJjKQNWLY1GSg3kesBvy5 H+oQyYQmT657jrXeiaauYnArBxq9mG48RgK3FVo8tcXz8evF8KTBNIEcH/ZTX5nN CBfI7DobQWfXyeyGfip7z2KrNnTdmEJgWUm+Y5wLM25VGnsMuih5G7/2Vp4utoRm PE3fwfbBk55IEQOs0YGy3+mhzDg51fjwsZSZwfGxGUqTxDXjLqbBR3ih1GyO3HqT etH4HKAnrIUVTXXOvryMhVX73FiJOg4= =HiqF -----END PGP SIGNATURE----- --=-=-=--