* [bug#66832] [PATCH] build-system: clojure: Use the standard error regarding cross builds.
@ 2023-10-30 8:43 Christopher Baines
2023-11-15 17:19 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: Christopher Baines @ 2023-10-30 8:43 UTC (permalink / raw)
To: 66832
Rather than raising an error in the build system.
* guix/build-system/clojure.scm (lower): Return #f for cross builds, rather
than calling error.
Change-Id: Id97c8f5140f55fe2c52ccb0db36fd993922c6a7e
---
guix/build-system/clojure.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/guix/build-system/clojure.scm b/guix/build-system/clojure.scm
index fb897356bc..037fcaf21d 100644
--- a/guix/build-system/clojure.scm
+++ b/guix/build-system/clojure.scm
@@ -83,8 +83,8 @@ (define* (lower name
#:clojure #:jdk #:zip)))
(if target
- (error "No cross-compilation for clojure-build-system yet: LOWER"
- target) ; FIXME
+ #f ; FIXME: No cross-compilation for
+ ; clojure-build-system yet
(bag (name name)
(system system)
(host-inputs `(,@(if source
base-commit: 642769707c05dc1dd5674d60cd3b55d77b35c9d9
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#66832] [PATCH] build-system: clojure: Use the standard error regarding cross builds.
2023-10-30 8:43 [bug#66832] [PATCH] build-system: clojure: Use the standard error regarding cross builds Christopher Baines
@ 2023-11-15 17:19 ` Ludovic Courtès
2023-11-20 15:10 ` bug#66832: " Christopher Baines
0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2023-11-15 17:19 UTC (permalink / raw)
To: Christopher Baines; +Cc: 66832
Christopher Baines <mail@cbaines.net> skribis:
> Rather than raising an error in the build system.
>
> * guix/build-system/clojure.scm (lower): Return #f for cross builds, rather
> than calling error.
>
> Change-Id: Id97c8f5140f55fe2c52ccb0db36fd993922c6a7e
LGTM!
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#66832: [PATCH] build-system: clojure: Use the standard error regarding cross builds.
2023-11-15 17:19 ` Ludovic Courtès
@ 2023-11-20 15:10 ` Christopher Baines
0 siblings, 0 replies; 3+ messages in thread
From: Christopher Baines @ 2023-11-20 15:10 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 66832-done
[-- Attachment #1: Type: text/plain, Size: 425 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Christopher Baines <mail@cbaines.net> skribis:
>
>> Rather than raising an error in the build system.
>>
>> * guix/build-system/clojure.scm (lower): Return #f for cross builds, rather
>> than calling error.
>>
>> Change-Id: Id97c8f5140f55fe2c52ccb0db36fd993922c6a7e
>
> LGTM!
Great, I've pushed this to master as
98ae8076435c74f90ad8ad30557963d2caa273c2.
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-20 15:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-30 8:43 [bug#66832] [PATCH] build-system: clojure: Use the standard error regarding cross builds Christopher Baines
2023-11-15 17:19 ` Ludovic Courtès
2023-11-20 15:10 ` bug#66832: " Christopher Baines
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.