all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Daniel Gerber <dg@atufi.org>
To: Jelle Licht <jlicht@fsfe.org>
Cc: 34526@debbugs.gnu.org
Subject: bug#34526: Updating node.js
Date: Tue, 19 Feb 2019 17:42:19 +0100	[thread overview]
Message-ID: <87h8cz20ic.fsf@atufi.org> (raw)
In-Reply-To: <877edw6cta.fsf@fsfe.org>

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

 
2019-02-18, Jelle Licht: 
 
> It seems that llhttp includes a build step for generating 
> C-files using TypeScript, making it a non-starter for proper 
> packaging in Guix. 
> 
> See https://github.com/nodejs/llhttp/issues/14 for more details, 
> but sadly no solution. 

What about statically linking llhttp's C "sources" included in 
node?   Building v11.10.0 succeeds with this:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: node-llhttp.patch --]
[-- Type: text/x-patch, Size: 383 bytes --]

diff --git a/node.gypi b/node.gypi
index c07b5ea704..c08493efbe 100644
--- a/node.gypi
+++ b/node.gypi
@@ -174,6 +174,12 @@
       ],
     } ],
 
+    [ 'node_shared_http_parser=="true"', {
+      'dependencies': [
+        'deps/llhttp/llhttp.gyp:llhttp'
+      ],
+    } ],
+
     [ 'node_shared_cares=="false"', {
       'dependencies': [ 'deps/cares/cares.gyp:cares' ],
     }],

  parent reply	other threads:[~2019-02-19 16:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-18 14:36 bug#34526: Updating node.js Daniel Gerber
2019-02-18 20:50 ` Jelle Licht
2019-02-19  8:06   ` Björn Höfling
2019-02-19 16:42   ` Daniel Gerber [this message]
2019-02-19 17:00     ` Daniel Gerber
2019-02-20 13:59     ` Jelle Licht
2019-02-21 17:02       ` Daniel Gerber
2019-11-16 20:28         ` Christopher Lemmer Webber
2019-11-17 18:25           ` Marius Bakke
2019-11-20 14:26             ` Christopher Lemmer Webber
2019-11-21 13:34               ` Jelle Licht
2020-04-20 20:49 ` [bug#34526] " Christopher Baines
2021-08-06  4:06   ` [bug#34526] Updating node from version 10 Maxim Cournoyer
2021-09-26  3:48 ` bug#34526: " Sarah Morgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8cz20ic.fsf@atufi.org \
    --to=dg@atufi.org \
    --cc=34526@debbugs.gnu.org \
    --cc=jlicht@fsfe.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.