From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Gerber <dg@atufi.org>
Subject: bug#34526: Updating node.js
Date: Tue, 19 Feb 2019 17:42:19 +0100
Message-ID: <87h8cz20ic.fsf@atufi.org>
References: <87d0npb1tx.fsf@atufi.org> <877edw6cta.fsf@fsfe.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:51879)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gw8T5-0007gM-QT
	for bug-guix@gnu.org; Tue, 19 Feb 2019 11:42:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gw8T5-0006QW-05
	for bug-guix@gnu.org; Tue, 19 Feb 2019 11:42:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:56187)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gw8T4-0006QJ-Qo
	for bug-guix@gnu.org; Tue, 19 Feb 2019 11:42:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gw8T4-0004Br-K0
	for bug-guix@gnu.org; Tue, 19 Feb 2019 11:42:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.34526.B34526.155059449216072@debbugs.gnu.org>
In-reply-to: <877edw6cta.fsf@fsfe.org>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Jelle Licht <jlicht@fsfe.org>
Cc: 34526@debbugs.gnu.org

--=-=-=
Content-Type: text/plain; format=flowed

 
2019-02-18, Jelle Licht: 
 
> It seems that llhttp includes a build step for generating 
> C-files using TypeScript, making it a non-starter for proper 
> packaging in Guix. 
> 
> See https://github.com/nodejs/llhttp/issues/14 for more details, 
> but sadly no solution. 

What about statically linking llhttp's C "sources" included in 
node?   Building v11.10.0 succeeds with this:


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline; filename=node-llhttp.patch

diff --git a/node.gypi b/node.gypi
index c07b5ea704..c08493efbe 100644
--- a/node.gypi
+++ b/node.gypi
@@ -174,6 +174,12 @@
       ],
     } ],
 
+    [ 'node_shared_http_parser=="true"', {
+      'dependencies': [
+        'deps/llhttp/llhttp.gyp:llhttp'
+      ],
+    } ],
+
     [ 'node_shared_cares=="false"', {
       'dependencies': [ 'deps/cares/cares.gyp:cares' ],
     }],

--=-=-=--