From: Marius Bakke <mbakke@fastmail.com>
To: Giacomo Leidi <goodoldpaul@autistici.org>, 38687@debbugs.gnu.org
Subject: [bug#38687] [PATCH 2/2] gnu: Add libtcod.
Date: Mon, 10 Feb 2020 22:19:41 +0100 [thread overview]
Message-ID: <87h7zy2l8y.fsf@devup.no> (raw)
In-Reply-To: <20200206201713.8535-2-goodoldpaul@autistici.org>
[-- Attachment #1: Type: text/plain, Size: 2066 bytes --]
Giacomo Leidi <goodoldpaul@autistici.org> writes:
> * gnu/packages/game-development.scm (libtcod): New variable.
[...]
> + (add-before 'bootstrap 'remove-hardcoded-vendor-paths
> + (lambda _
> + (substitute* "sources.am"
> + (("\\.\\./\\.\\./src/vendor/lodepng\\.cpp \\\\\n") "")
> + (("\\.\\./\\.\\./src/vendor/stb\\.c \\\\")
> + "../../src/vendor/stb.c")
> + (("\\.\\./\\.\\./src/vendor/utf8proc/utf8proc\\.c") ""))
> +
> + (substitute* "../../src/libtcod/sys_sdl_img_png.cpp"
> + (("\\.\\./vendor/") ""))
> +
> + (substitute* '("../../src/libtcod/color/canvas.cpp"
> + "../../src/libtcod/sys_sdl_img_png.cpp"
> + "../../src/libtcod/tileset/truetype.cpp"
> + "../../src/libtcod/tileset/tilesheet.cpp")
> + (("\\.\\./\\.\\./vendor/") ""))
> +
> + (substitute* "../../src/libtcod/console/printing.cpp"
> + (("\\.\\./\\.\\./vendor/utf8proc/") ""))
> + #t)))))
Can you move the contents of this phase to the 'snippet' instead? Since
they are related to the unbundling, and makes 'guix build --source
libtcod' easier to work with.
> + (native-inputs
> + `(("autoconf" ,autoconf)
> + ("automake" ,automake)
> + ("libtool" ,libtool)
> + ("lodepng" ,lodepng)
> + ("python" ,python)
> + ("pkg-config" ,pkg-config)
> + ("sdl2" ,sdl2)
sdl2 and lodepng should probably be regular inputs.
> + ("stb-sprintf" ,stb-sprintf)
> + ("stb-truetype" ,stb-truetype)))
> + (inputs
> + `(("utf8proc" ,utf8proc)
> + ("zlib" ,zlib)))
> + (home-page "https://github.com/libtcod/libtcod")
> + (synopsis "Library specifically designed for writing roguelikes")
> + (description
> + "libtcod is a free, fast, portable and uncomplicated API for roguelike
s/free// (everything in Guix is free software)
Otherwise LGTM!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-02-10 21:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 12:37 [bug#38687] [PATCH] gnu: Add libtcod Giacomo Leidi
2019-12-23 18:37 ` Ludovic Courtès
2020-01-22 11:11 ` goodoldpaul
2020-01-22 18:57 ` Marius Bakke
2020-02-06 20:16 ` goodoldpaul
2020-02-10 21:10 ` Marius Bakke
2020-02-06 20:17 ` [bug#38687] [PATCH 1/2] gnu: Add lodepng Giacomo Leidi
2020-02-06 20:17 ` [bug#38687] [PATCH 2/2] gnu: Add libtcod Giacomo Leidi
2020-02-10 21:19 ` Marius Bakke [this message]
2020-02-16 21:53 ` [bug#38687] " goodoldpaul
2020-02-24 20:56 ` bug#38687: " Marius Bakke
2020-02-10 21:14 ` [bug#38687] [PATCH 1/2] gnu: Add lodepng Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7zy2l8y.fsf@devup.no \
--to=mbakke@fastmail.com \
--cc=38687@debbugs.gnu.org \
--cc=goodoldpaul@autistici.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.