* bug#55326: libgit2 1.3.0 includes a time-dependent test
@ 2022-05-08 21:06 Ludovic Courtès
2022-05-08 22:11 ` Ludovic Courtès
2022-06-03 17:58 ` Maxime Devos
0 siblings, 2 replies; 10+ messages in thread
From: Ludovic Courtès @ 2022-05-08 21:06 UTC (permalink / raw)
To: 55326
libgit2 1.3.0 (and 1.4.3, it seems) includes a time-dependent test:
‘refs::revparse::date’, in ‘tests/refs/revparse.c’, assumes
“HEAD@{10 years ago}” doesn't match anything in the sample repositories,
which is no longer true:
--8<---------------cut here---------------start------------->8---
$ date
Sun May 8 11:04:31 PM CEST 2022
$ ./libgit2_clar -v -Q -srefs::revparse::date
Loaded 404 suites:
Started (test status codes: OK='.' FAILURE='F' SKIPPED='S')
refs::revparseF
1) Failure:
refs::revparse::date [/tmp/guix-build-libgit2-1.3.0.drv-0/source/tests/refs/revparse.c:31]
Function call succeeded: error
no error, expected non-zero return
$ /gnu/store/wy3ww7znqhlg84vg6cmw1m12z1drxwh1-libfaketime-0.9.9/bin/faketime 2021-12-12 ./libgit2_clar -v -Q -srefs::revparse::date
Loaded 404 suites:
Started (test status codes: OK='.' FAILURE='F' SKIPPED='S')
refs::revparse.
--8<---------------cut here---------------end--------------->8---
Thus, as of 6b588da368c77cde82ea2f22ca315116228777ad, libgit2 now fails
to build; a few months ago, it would build fine.
Ludo’.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#55326: libgit2 1.3.0 includes a time-dependent test
2022-05-08 21:06 bug#55326: libgit2 1.3.0 includes a time-dependent test Ludovic Courtès
@ 2022-05-08 22:11 ` Ludovic Courtès
2022-05-09 7:25 ` Maxime Devos
2022-06-03 17:58 ` Maxime Devos
1 sibling, 1 reply; 10+ messages in thread
From: Ludovic Courtès @ 2022-05-08 22:11 UTC (permalink / raw)
To: 55326-done
Ludovic Courtès <ludo@gnu.org> skribis:
> libgit2 1.3.0 (and 1.4.3, it seems) includes a time-dependent test:
> ‘refs::revparse::date’, in ‘tests/refs/revparse.c’, assumes
> “HEAD@{10 years ago}” doesn't match anything in the sample repositories,
> which is no longer true:
Fixed:
e48b5484afde93294c4ed7215e88ed450842b2e5 (master)
f5fe0082abe4547f3fb9f29d8351473cfb3a387b (staging)
Ludo’.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#55326: libgit2 1.3.0 includes a time-dependent test
2022-05-08 22:11 ` Ludovic Courtès
@ 2022-05-09 7:25 ` Maxime Devos
2022-05-09 8:49 ` Ludovic Courtès
2022-05-09 19:33 ` Carl Dong
0 siblings, 2 replies; 10+ messages in thread
From: Maxime Devos @ 2022-05-09 7:25 UTC (permalink / raw)
To: Ludovic Courtès, 55326-done
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
Ludovic Courtès schreef op ma 09-05-2022 om 00:11 [+0200]:
> Fixed:
>
> e48b5484afde93294c4ed7215e88ed450842b2e5 (master)
> f5fe0082abe4547f3fb9f29d8351473cfb3a387b (staging)
It's still time-dependent though:
> + (substitute* "tests/refs/revparse.c"
> + (("10 years ago")
> + "100 years ago"))))))
wouldn't it now fail after ~100 or ~1000 years?
Though maybe by that time, we have complete time namespaces ...
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#55326: libgit2 1.3.0 includes a time-dependent test
2022-05-09 7:25 ` Maxime Devos
@ 2022-05-09 8:49 ` Ludovic Courtès
2022-05-09 10:10 ` Maxime Devos
2022-05-09 19:33 ` Carl Dong
1 sibling, 1 reply; 10+ messages in thread
From: Ludovic Courtès @ 2022-05-09 8:49 UTC (permalink / raw)
To: Maxime Devos; +Cc: 55326-done
Maxime Devos <maximedevos@telenet.be> skribis:
> Ludovic Courtès schreef op ma 09-05-2022 om 00:11 [+0200]:
>> Fixed:
>>
>> e48b5484afde93294c4ed7215e88ed450842b2e5 (master)
>> f5fe0082abe4547f3fb9f29d8351473cfb3a387b (staging)
>
> It's still time-dependent though:
>
>> + (substitute* "tests/refs/revparse.c"
>> + (("10 years ago")
>> + "100 years ago"))))))
>
> wouldn't it now fail after ~100 or ~1000 years?
> Though maybe by that time, we have complete time namespaces ...
Right, and remaining computers will have RISC-VII 100 MHz CPUs anyway.
Ludo’.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#55326: libgit2 1.3.0 includes a time-dependent test
2022-05-09 8:49 ` Ludovic Courtès
@ 2022-05-09 10:10 ` Maxime Devos
2022-05-10 15:50 ` Ludovic Courtès
0 siblings, 1 reply; 10+ messages in thread
From: Maxime Devos @ 2022-05-09 10:10 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 55326-done
[-- Attachment #1: Type: text/plain, Size: 235 bytes --]
Ludovic Courtès schreef op ma 09-05-2022 om 10:49 [+0200]:
> Right, and remaining computers will have RISC-VII 100 MHz CPUs anyway.
I assume you meant 100GHz here instead? Or very fast software that
doesn't need fast CPUs ...
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#55326: libgit2 1.3.0 includes a time-dependent test
2022-05-09 7:25 ` Maxime Devos
2022-05-09 8:49 ` Ludovic Courtès
@ 2022-05-09 19:33 ` Carl Dong
2022-05-10 15:48 ` Ludovic Courtès
1 sibling, 1 reply; 10+ messages in thread
From: Carl Dong @ 2022-05-09 19:33 UTC (permalink / raw)
To: Maxime Devos; +Cc: Ludovic Courtès, 55326-done
[-- Attachment #1.1: Type: text/plain, Size: 1008 bytes --]
I opened a pull request upstream that just removes the specific test for “HEAD@{10 years ago}". Since that functionality is well-covered by subsequent tests.
See here for the PR: https://github.com/libgit2/libgit2/pull/6299 <https://github.com/libgit2/libgit2/pull/6299>
> Though maybe by that time, we have complete time namespaces …
One would hope!
Cheers,
Carl Dong
> On May 9, 2022, at 3:25 AM, Maxime Devos <maximedevos@telenet.be> wrote:
>
> Ludovic Courtès schreef op ma 09-05-2022 om 00:11 [+0200]:
>> Fixed:
>>
>> e48b5484afde93294c4ed7215e88ed450842b2e5 (master)
>> f5fe0082abe4547f3fb9f29d8351473cfb3a387b (staging)
>
> It's still time-dependent though:
>
>> + (substitute* "tests/refs/revparse.c"
>> + (("10 years ago")
>> + "100 years ago"))))))
>
> wouldn't it now fail after ~100 or ~1000 years?
> Though maybe by that time, we have complete time namespaces ...
>
> Greetings,
> Maxime.
[-- Attachment #1.2: Type: text/html, Size: 2312 bytes --]
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#55326: libgit2 1.3.0 includes a time-dependent test
2022-05-09 19:33 ` Carl Dong
@ 2022-05-10 15:48 ` Ludovic Courtès
0 siblings, 0 replies; 10+ messages in thread
From: Ludovic Courtès @ 2022-05-10 15:48 UTC (permalink / raw)
To: Carl Dong; +Cc: Maxime Devos, 55326-done
Heya,
Carl Dong <contact@carldong.me> skribis:
> I opened a pull request upstream that just removes the specific test for “HEAD@{10 years ago}". Since that functionality is well-covered by subsequent tests.
>
> See here for the PR: https://github.com/libgit2/libgit2/pull/6299 <https://github.com/libgit2/libgit2/pull/6299>
Well done, thanks!
Ludo’.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#55326: libgit2 1.3.0 includes a time-dependent test
2022-05-09 10:10 ` Maxime Devos
@ 2022-05-10 15:50 ` Ludovic Courtès
0 siblings, 0 replies; 10+ messages in thread
From: Ludovic Courtès @ 2022-05-10 15:50 UTC (permalink / raw)
To: Maxime Devos; +Cc: 55326-done
Maxime Devos <maximedevos@telenet.be> skribis:
> Ludovic Courtès schreef op ma 09-05-2022 om 10:49 [+0200]:
>> Right, and remaining computers will have RISC-VII 100 MHz CPUs anyway.
>
> I assume you meant 100GHz here instead? Or very fast software that
> doesn't need fast CPUs ...
I did mean MHz but I don’t want to spoil more hopeful visions. :-)
Ludo’.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#55326: libgit2 1.3.0 includes a time-dependent test
2022-05-08 21:06 bug#55326: libgit2 1.3.0 includes a time-dependent test Ludovic Courtès
2022-05-08 22:11 ` Ludovic Courtès
@ 2022-06-03 17:58 ` Maxime Devos
2022-06-08 16:16 ` Ludovic Courtès
1 sibling, 1 reply; 10+ messages in thread
From: Maxime Devos @ 2022-06-03 17:58 UTC (permalink / raw)
To: Ludovic Courtès, 55326
[-- Attachment #1: Type: text/plain, Size: 230 bytes --]
I noticed that the latest core-updates evaluations fail because of the
test failure in libgit2@1.3.0:
https://ci.guix.gnu.org/jobset/core-updates
so I recommend merging 'master' into 'core-updates'.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#55326: libgit2 1.3.0 includes a time-dependent test
2022-06-03 17:58 ` Maxime Devos
@ 2022-06-08 16:16 ` Ludovic Courtès
0 siblings, 0 replies; 10+ messages in thread
From: Ludovic Courtès @ 2022-06-08 16:16 UTC (permalink / raw)
To: Maxime Devos; +Cc: 55326
Maxime Devos <maximedevos@telenet.be> skribis:
> I noticed that the latest core-updates evaluations fail because of the
> test failure in libgit2@1.3.0:
>
> https://ci.guix.gnu.org/jobset/core-updates
>
> so I recommend merging 'master' into 'core-updates'.
Done in 8c3e9da13a3c92a7db308db8c0d81cb474ad7799 (and I hope I didn’t
mess up while resolving conflicts!)
Ludo’.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-06-08 16:19 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-08 21:06 bug#55326: libgit2 1.3.0 includes a time-dependent test Ludovic Courtès
2022-05-08 22:11 ` Ludovic Courtès
2022-05-09 7:25 ` Maxime Devos
2022-05-09 8:49 ` Ludovic Courtès
2022-05-09 10:10 ` Maxime Devos
2022-05-10 15:50 ` Ludovic Courtès
2022-05-09 19:33 ` Carl Dong
2022-05-10 15:48 ` Ludovic Courtès
2022-06-03 17:58 ` Maxime Devos
2022-06-08 16:16 ` Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.