From: Distopico <distopico@riseup.net>
To: Saku Laesvuori <saku@laesvuori.fi>
Cc: Raghav Gururajan <rg@raghavgururajan.name>,
64748@debbugs.gnu.org, hako@ultrarare.space
Subject: [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8
Date: Mon, 24 Jul 2023 12:07:12 -0500 [thread overview]
Message-ID: <87h6ptnsb3.fsf@riseup.net> (raw)
In-Reply-To: <20230722082516.yh5nwyfllmwzgjqu@X-kone>
I just tested trying to replace all the libsrtp but not luck from side,
they use for example:
- third_party/libsrtp/crypto/include/crypto_types.h
- third_party/libsrtp/include/srtp.h
not exposed by "libsrtp" package, also they use a custom configuration
for that library
https://github.com/desktop-app/tg_owt/blob/master/src/third_party/libsrtp_config/config.h
Also there is many other references to `libsrtp` .C source code
https://github.com/desktop-app/tg_owt/blob/a45d8b8f0a99bd0e5118dda1dc4a8b7b3ad5dcfd/cmake/libsrtp.cmake#L4
I was checking nix implementation and they just use the submodules
https://github.com/NixOS/nixpkgs/blob/nixos-23.05/pkgs/applications/networking/instant-messengers/telegram/telegram-desktop/tg_owt.nix#L19
and not "srtp" package.
So I think the patch that i sent is a good solution, similar to the nix
one, but if someone else want to try another option would be great.
On 2023-07-22, Saku Laesvuori <saku@laesvuori.fi> wrote:
> [[PGP Signed Part:Undecided]]
>> If libsrtp in Guix uses something other than openssl by default, then we
>> could create a package-definition "libsrtp-openssl" which inherits from
>> "libsrtp" and build-flagged to use openssl. We can then use that for
>> telegram desktop.
>
> Yes, but we would still need to patch webrtc-for-telegram-desktop as the
> code currently refers to headers in the submodule directory. Now that I
> think of it, it could actually be relatively easy with a regex substitution
> (something like s!^#include "third_party/(srtp/[^"]*)"$!#include <\1>!)
> on every file. That's of course assuming that the code only refers to
> headers in the submodule.
>
> [[End of PGP Signed Part]]
next prev parent reply other threads:[~2023-07-24 17:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 17:18 [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8 Distopico
2023-07-20 19:33 ` Saku Laesvuori via Guix-patches via
2023-07-20 20:21 ` Distopico
2023-07-20 21:06 ` Saku Laesvuori via Guix-patches via
2023-07-20 23:09 ` Distopico
2023-07-21 7:22 ` Saku Laesvuori via Guix-patches via
2023-07-22 6:36 ` Raghav Gururajan via Guix-patches via
2023-07-22 8:25 ` Saku Laesvuori via Guix-patches via
2023-07-24 17:07 ` Distopico [this message]
2023-07-24 20:17 ` Raghav Gururajan via Guix-patches via
2023-07-26 7:24 ` Saku Laesvuori via Guix-patches via
2023-07-26 18:54 ` Distopico
2023-07-20 23:26 ` [bug#64748] [PATCH v2] " Distopico
2023-07-26 18:54 ` [bug#64748] [PATCH v3] " Distopico
2023-07-26 19:13 ` Saku Laesvuori via Guix-patches via
2023-07-26 19:22 ` Distopico
2023-07-26 19:21 ` [bug#64748] [PATCH v4] " Distopico
2023-07-26 20:09 ` Saku Laesvuori via Guix-patches via
2023-08-05 2:59 ` [bug#64748] [PATCH] " Distopico
2023-08-07 9:38 ` Hilton Chain via Guix-patches via
2023-08-07 12:26 ` Hilton Chain via Guix-patches via
2023-08-28 13:30 ` [bug#64748] [PATCH v6 0/2] gnu: webrtc-for-telegram-desktop: Update to 0-389.0532942 Hilton Chain via Guix-patches via
2023-08-28 13:31 ` [bug#64748] [PATCH v6 1/2] gnu: libyuv-for-telegram-desktop: Update to 0-2439.77c2121 Hilton Chain via Guix-patches via
2023-08-28 13:31 ` [bug#64748] [PATCH v6 2/2] gnu: webrtc-for-telegram-desktop: Update to 0-389.0532942 Hilton Chain via Guix-patches via
2023-08-28 14:56 ` [bug#64748] [PATCH v7 0/2] " Hilton Chain via Guix-patches via
2023-08-28 15:00 ` [bug#64748] [PATCH v7 1/2] gnu: libyuv-for-telegram-desktop: Update to 0-2439.77c2121 Hilton Chain via Guix-patches via
2023-08-28 15:00 ` [bug#64748] [PATCH v7 2/2] gnu: webrtc-for-telegram-desktop: Update to 0-389.0532942 Hilton Chain via Guix-patches via
2023-08-29 18:13 ` Distopico
2023-09-01 9:01 ` bug#64748: " Hilton Chain via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6ptnsb3.fsf@riseup.net \
--to=distopico@riseup.net \
--cc=64748@debbugs.gnu.org \
--cc=hako@ultrarare.space \
--cc=rg@raghavgururajan.name \
--cc=saku@laesvuori.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.