From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id MJDZJCSyvmRwjgAASxT56A (envelope-from ) for ; Mon, 24 Jul 2023 19:17:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 4N7VJCSyvmQfiQAA9RJhRA (envelope-from ) for ; Mon, 24 Jul 2023 19:17:24 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 396885A1AE for ; Mon, 24 Jul 2023 19:17:24 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=riseup.net header.s=squak header.b=EhebYfzS; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1690219044; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=ftfjIeq+Evdq5yMUR7o6jQBnRWsi64cZ0vGKua5eCOs=; b=dl5pADi4d/eKNd6uHPmoqhsLX/1MPAswwuicipfyj/r5iMHGzv/184FSkZ/EXxIJuFSYZd La47z/x0auv3S8E0e+DAl/hoHkGtAQzs7ZwPM6qPqBj1mZoL/YYAOFu/Ntn3gkVVQTftES X3FlgKBgcJ7RYEs29Q6n4sL1/IK1OHmjCCzLxZw+v9BTdAeXcJIQrpodxPn+e6IRG909Ts qjfxKHx+L9CU5IArARuM2FCuRBpTbLHzXKdMquuIERxx7Wls752aPgifBxgXpSZ7GPjOBM eFjKOIeXnbJkIP6POThk3nez/mDz9XWW9iD944cHwvyM+04oU5d4o6Kiufc4+w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=riseup.net header.s=squak header.b=EhebYfzS; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1690219044; a=rsa-sha256; cv=none; b=aw79/k4UzM0BStwgfHAWrDsCpk7uaRY+kWqiF+6WTe352hSwriwtjKdrq7dpSRXAj+/Dvt ZrxY+nxQ8O38SfZTeiRyf4hs5DFfgY5wlGLD6T2mnmDYV6cZGq5Y+JSi9n5d1omlZ2xHl0 BImefLT4qLc7M41FNHBpKK1We5zlkYu8/hoBUOzCLosstzzgAK/bc/pt3z9pnHlrLGlEh5 de5jH4Bd/m4YWJZ1adqKgihvEhijrpnuioLT+psr9gp1ai2zZOqwXB1aHjDmgHJUngpzOM PeZAJLx8oRx/JwRVQWSqBBepgV7qKSsr940YObBzyxCSiSZe7xUPWssqSuvarg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qNzBK-0008Va-Ko; Mon, 24 Jul 2023 13:17:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNzB8-0008QS-04 for guix-patches@gnu.org; Mon, 24 Jul 2023 13:17:06 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qNzB7-0003ve-OP for guix-patches@gnu.org; Mon, 24 Jul 2023 13:17:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qNzB7-00060m-Jq for guix-patches@gnu.org; Mon, 24 Jul 2023 13:17:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8 Resent-From: Distopico Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 24 Jul 2023 17:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64748 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Saku Laesvuori Cc: Raghav Gururajan , 64748@debbugs.gnu.org, hako@ultrarare.space Received: via spool by 64748-submit@debbugs.gnu.org id=B64748.169021900423078 (code B ref 64748); Mon, 24 Jul 2023 17:17:01 +0000 Received: (at 64748) by debbugs.gnu.org; 24 Jul 2023 17:16:44 +0000 Received: from localhost ([127.0.0.1]:43930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNzAp-000609-KI for submit@debbugs.gnu.org; Mon, 24 Jul 2023 13:16:43 -0400 Received: from mx0.riseup.net ([198.252.153.6]:35438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNzAn-0005zr-Od for 64748@debbugs.gnu.org; Mon, 24 Jul 2023 13:16:43 -0400 Received: from fews02-sea.riseup.net (fews02-sea-pn.riseup.net [10.0.1.112]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx0.riseup.net (Postfix) with ESMTPS id 4R8mzR6JX7z9tJW; Mon, 24 Jul 2023 17:16:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1690218996; bh=+15s1wbDbCcdD6/nQ24oPYZrqk9krsicqQVEbVDLtSA=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=EhebYfzSfZa8V0EsTDyTeA1X97ukV/lOVrMYR3/zbBiiJ5GeZuM8p01DRNcncwOP5 6L6WWdDuIAEJceWyULp6umL8ckr3fC+oiE3CMAwo0nD78tZ6THaSZwtqU2Tl4y0Nux jVWzoxo/FCLDTH02SkkJgWyu7P1d3XpIfLkwtNok= X-Riseup-User-ID: 84B1CB0A8BC32ABC46D02C6D79861DE0669782974CBF07CCD83412D89E7B89A4 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews02-sea.riseup.net (Postfix) with ESMTPSA id 4R8mzQ2jPMzFqjM; Mon, 24 Jul 2023 17:16:34 +0000 (UTC) References: <20230720171841.31901-1-distopico@riseup.net> <20230720193353.gb75xe2ywl6nfvnr@X-kone> <87a5vq9vr7.fsf@riseup.net> <20230720210600.2zwjtcdnoa63rmo4@X-kone> <87zg3q897e.fsf@riseup.net> <20230721072242.eso6juxdbhpdkgex@X-kone> <20230722082516.yh5nwyfllmwzgjqu@X-kone> From: Distopico Date: Mon, 24 Jul 2023 12:07:12 -0500 In-reply-to: <20230722082516.yh5nwyfllmwzgjqu@X-kone> Message-ID: <87h6ptnsb3.fsf@riseup.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: 3.20 X-Migadu-Queue-Id: 396885A1AE X-Migadu-Spam-Score: 3.20 X-Migadu-Scanner: mx0.migadu.com X-TUID: /pviZcSCWZwN I just tested trying to replace all the libsrtp but not luck from side, they use for example: - third_party/libsrtp/crypto/include/crypto_types.h - third_party/libsrtp/include/srtp.h not exposed by "libsrtp" package, also they use a custom configuration for that library https://github.com/desktop-app/tg_owt/blob/master/src/third_party/libsrtp_config/config.h Also there is many other references to `libsrtp` .C source code https://github.com/desktop-app/tg_owt/blob/a45d8b8f0a99bd0e5118dda1dc4a8b7b3ad5dcfd/cmake/libsrtp.cmake#L4 I was checking nix implementation and they just use the submodules https://github.com/NixOS/nixpkgs/blob/nixos-23.05/pkgs/applications/networking/instant-messengers/telegram/telegram-desktop/tg_owt.nix#L19 and not "srtp" package. So I think the patch that i sent is a good solution, similar to the nix one, but if someone else want to try another option would be great. On 2023-07-22, Saku Laesvuori wrote: > [[PGP Signed Part:Undecided]] >> If libsrtp in Guix uses something other than openssl by default, then we >> could create a package-definition "libsrtp-openssl" which inherits from >> "libsrtp" and build-flagged to use openssl. We can then use that for >> telegram desktop. > > Yes, but we would still need to patch webrtc-for-telegram-desktop as the > code currently refers to headers in the submodule directory. Now that I > think of it, it could actually be relatively easy with a regex substitution > (something like s!^#include "third_party/(srtp/[^"]*)"$!#include <\1>!) > on every file. That's of course assuming that the code only refers to > headers in the submodule. > > [[End of PGP Signed Part]]