* [bug#65444] [PATCH] gnu-maintenance: Improve check for disabled host names.
@ 2023-08-21 20:56 Maxim Cournoyer
2023-08-22 16:28 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: Maxim Cournoyer @ 2023-08-21 20:56 UTC (permalink / raw)
To: 65444, maxim.cournoyer
Cc: Christopher Baines, Josselin Poiret, Ludovic Courtès,
Mathieu Othacehe, Ricardo Wurmus, Simon Tournier,
Tobias Geerinckx-Rice
Found while investigating <https://issues.guix.gnu.org/65304>.
* guix/gnu-maintenance.scm (html-updatable-package?): Tighten predicate.
---
guix/gnu-maintenance.scm | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/guix/gnu-maintenance.scm b/guix/gnu-maintenance.scm
index 32712f7218..5c16a7617d 100644
--- a/guix/gnu-maintenance.scm
+++ b/guix/gnu-maintenance.scm
@@ -846,7 +846,11 @@ (define html-updatable-package?
(let ((scheme (uri-scheme uri))
(host (uri-host uri)))
(and (memq scheme '(http https))
- (not (member host hosting-sites)))))))))
+ ;; HOST may contain prefixes,
+ ;; e.g. "profanity-im.github.io", hence the
+ ;; suffix-based test below.
+ (not (any (cut string-suffix? <> host)
+ hosting-sites)))))))))
(lambda (package)
(or (assoc-ref (package-properties package) 'release-monitoring-url)
base-commit: 4c7627dfec88350f9a1705e9527c38dd41506f8b
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* [bug#65444] [PATCH] gnu-maintenance: Improve check for disabled host names.
2023-08-21 20:56 [bug#65444] [PATCH] gnu-maintenance: Improve check for disabled host names Maxim Cournoyer
@ 2023-08-22 16:28 ` Ludovic Courtès
2023-08-25 14:08 ` bug#65444: " Maxim Cournoyer
0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2023-08-22 16:28 UTC (permalink / raw)
To: Maxim Cournoyer
Cc: Josselin Poiret, Simon Tournier, Mathieu Othacehe,
Tobias Geerinckx-Rice, 65444, Ricardo Wurmus, Christopher Baines
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> Found while investigating <https://issues.guix.gnu.org/65304>.
>
> * guix/gnu-maintenance.scm (html-updatable-package?): Tighten predicate.
LGTM!
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#65444: [PATCH] gnu-maintenance: Improve check for disabled host names.
2023-08-22 16:28 ` Ludovic Courtès
@ 2023-08-25 14:08 ` Maxim Cournoyer
0 siblings, 0 replies; 3+ messages in thread
From: Maxim Cournoyer @ 2023-08-25 14:08 UTC (permalink / raw)
To: Ludovic Courtès
Cc: Josselin Poiret, 65444-done, Simon Tournier, Mathieu Othacehe,
Tobias Geerinckx-Rice, Ricardo Wurmus, Christopher Baines
Hello,
Ludovic Courtès <ludo@gnu.org> writes:
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> Found while investigating <https://issues.guix.gnu.org/65304>.
>>
>> * guix/gnu-maintenance.scm (html-updatable-package?): Tighten predicate.
>
> LGTM!
This change was installed with
c655231b72ac28b5a433069fcf86a835c9c83691. Thanks for the review!
--
Thanks,
Maxim
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-25 14:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-21 20:56 [bug#65444] [PATCH] gnu-maintenance: Improve check for disabled host names Maxim Cournoyer
2023-08-22 16:28 ` Ludovic Courtès
2023-08-25 14:08 ` bug#65444: " Maxim Cournoyer
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.