all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org>
To: 70029@debbugs.gnu.org
Cc: csantosb@inventati.org
Subject: [bug#70029] [PATCH] gnu: Add emacs-eglot-jl.
Date: Wed, 27 Mar 2024 16:59:03 +0100	[thread overview]
Message-ID: <87h6gris3c.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <ecc51538ce9f5ff8c339cd75870737cf75cf4b96.1711547888.git.csantosb@inventati.org> (Cayetano Santos via Guix-patches via's message of "Wed, 27 Mar 2024 14:58:08 +0100")

Hello,

Cayetano Santos via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-eglot-jl): New variable.

Thanks.

> +(define-public emacs-eglot-jl
> +  (package
> +    (name "emacs-eglot-jl")
> +    (version "2.3.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri
> +        (git-reference
> +         (url "https://github.com/non-Jedi/eglot-jl.git")

Nitpick: I think ".git" suffixes are usually removed.

> +         (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "144q4fj3am165vf1vx2ljlsmpn8vvvs1b95qi3rxlwqskkx0lig3"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs (list emacs-eglot))
> +    (arguments
> +     '(#:include '("^[^/]+.el$"
> +                   "^[^/]+.jl$"
> +                   "^[^/]+.toml$")))

This is a bit verbose, and ignores %default-include variable. I suggest
(using G-expressions just because we can)

(arguments (list #:include #~(cons "\\.(jl|toml)$" %default-include)))

> +    (home-page "https://github.com/non-Jedi/eglot-jl")
> +    (synopsis "Julia support for eglot")

Nitpick: Julia support for Eglot

> +    (description
> +     "This package adds support for @code{emacs-eglot} to the Julia language.")

Nitpick: ... support for Eglot to the Julia language.

> +    (license:cc-by2.0)))

I think there is a typo here. You mean

  (license license:cc-by2.0)

However, it seems to licensed under CC0 terms.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou






  reply	other threads:[~2024-03-27 16:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27 13:58 [bug#70029] [PATCH] gnu: Add emacs-eglot-jl Cayetano Santos via Guix-patches via
2024-03-27 15:59 ` Nicolas Goaziou via Guix-patches via [this message]
2024-03-28  8:55 ` [bug#70029] [PATCH v1] " Cayetano Santos via Guix-patches via
2024-03-29 12:29   ` Nicolas Goaziou via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6gris3c.fsf@nicolasgoaziou.fr \
    --to=guix-patches@gnu.org \
    --cc=70029@debbugs.gnu.org \
    --cc=csantosb@inventati.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.