From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id MH2XM8FCBGbIZQEAe85BDQ:P1 (envelope-from ) for ; Wed, 27 Mar 2024 17:01:06 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id MH2XM8FCBGbIZQEAe85BDQ (envelope-from ) for ; Wed, 27 Mar 2024 17:01:05 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=nicolasgoaziou.fr header.s=mailo header.b=w69BmnTv; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1711555265; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=fC+Gx88jbMsghZtvzeejdtOCN1eAHfHCLC/wMVVahjc=; b=qMh4n/6ObGHx01SWiPdQ597mdrhBOVVdxAbvlsYlzBre+TgRHGFuZUYZDy2icEPt7K68Gf U0YvFvZJ2gb5hvAgyN1cB0wzfcA1j9NthvyNhSNsfcTnElZf1C1YTRqcvqUKbBtZSaPUHN vGQb61LtCQ65FZnP9DbS6PsPaolgmD51lpQhAKz5TNz5GIfO5x6m86SknChArqwCzEHBt/ Cv4eiOD7GbFneGBFk/wm3mWsl3eNuh7AWgu5ewnkYOmFjEgUAJgGuNPtM83PUmGxv2oDCe mHhuPZFntv3cB6QwN7Zo6NgJBrH8Zyi4QyHNg/J6lGjzl6xWyA7bmzhz1HRX6w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=nicolasgoaziou.fr header.s=mailo header.b=w69BmnTv; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1711555265; a=rsa-sha256; cv=none; b=RolEK8ANSZtxYd54H+/U85SxPlRJw7F9B8ox4CNwkAxSvn3oTUxojaAuVsXfb5Trk+4O6A AYkz4lBYn3Xukrp2qjx7Cx8SFtWeqG0JnNP77q87WmSbxubNJTJIVuOhri5PZ99JOhZv+3 JdJy0CS7G5NqF58U1Y9CLTxxgrFXMwg/zVwIehfxWV1y27HICEUgJfT7HYDk3M3S7plJia 3mW9aRakZGwnTgpFK415OIV9l3VZFJrh0xNVLv/piOWzVonVhnqPYrl7Hu6eSYzJL1yNi4 IjIPBacSxjpK6LeQ+mJ25lLA49budk/JA2065sRaNdEDKyyBXgKqU5uqsn1ATw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 575C13CE9C for ; Wed, 27 Mar 2024 17:01:05 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rpVhp-0000yE-EU; Wed, 27 Mar 2024 12:00:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpVhD-0000u7-BU for guix-patches@gnu.org; Wed, 27 Mar 2024 12:00:12 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rpVh4-0006LX-Pu for guix-patches@gnu.org; Wed, 27 Mar 2024 12:00:10 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rpVh4-0005J6-Lr for guix-patches@gnu.org; Wed, 27 Mar 2024 12:00:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70029] [PATCH] gnu: Add emacs-eglot-jl. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 27 Mar 2024 16:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70029 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 70029@debbugs.gnu.org Cc: csantosb@inventati.org X-Debbugs-Original-To: Cayetano Santos via Guix-patches via X-Debbugs-Original-Cc: 70029@debbugs.gnu.org, Cayetano Santos Received: via spool by submit@debbugs.gnu.org id=B.171155517920225 (code B ref -1); Wed, 27 Mar 2024 16:00:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Mar 2024 15:59:39 +0000 Received: from localhost ([127.0.0.1]:38221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpVgh-0005G9-4l for submit@debbugs.gnu.org; Wed, 27 Mar 2024 11:59:39 -0400 Received: from lists.gnu.org ([2001:470:142::17]:39322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpVgY-0005F4-JV for submit@debbugs.gnu.org; Wed, 27 Mar 2024 11:59:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpVgS-0000q7-SP for guix-patches@gnu.org; Wed, 27 Mar 2024 11:59:24 -0400 Received: from msg-1.mailo.com ([213.182.54.11] helo=mailo.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpVgR-0006HR-4d for guix-patches@gnu.org; Wed, 27 Mar 2024 11:59:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nicolasgoaziou.fr; s=mailo; t=1711555160; bh=ACs8JAfuXjxPVlt91wynMDaVAz/jR1IQWaG9CYR4NQM=; h=X-EA-Auth:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type; b=w69BmnTv3ASt52YByJopzTeSHp+HKyKlHgQGHLHoXgjljU0F/badPhoCoZbHt9H8U TtOgDhpqGCSt+AeC32saWkNAw1PBswgFiKteSj2Qlhe4YMcaTZ8PP6MaoMpCylbReU kiqt2rZPwxbFdPdHRWlM247kDCRdnAke+frkt/KQ= Received: by b221-1.in.mailobj.net [192.168.90.21] with ESMTP via ip-20.mailobj.net [213.182.54.20] Wed, 27 Mar 2024 16:59:19 +0100 (CET) X-EA-Auth: LJkvIpgkJHwP1srrVLgM5zHj43FavzEwMd1WHlamv8bczJoyXitQVyVTjNxApkM0Rh3Yv2Kqub4z/T4jOto8jfu8GTLldp4bzFPNBfLsCuM= In-Reply-To: (Cayetano Santos via Guix-patches via's message of "Wed, 27 Mar 2024 14:58:08 +0100") References: Date: Wed, 27 Mar 2024 16:59:03 +0100 Message-ID: <87h6gris3c.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=213.182.54.11; envelope-from=mail@nicolasgoaziou.fr; helo=mailo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Goaziou X-ACL-Warn: , Nicolas Goaziou via Guix-patches From: Nicolas Goaziou via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -6.85 X-Migadu-Queue-Id: 575C13CE9C X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -6.85 X-TUID: 07wgISICvNZc Hello, Cayetano Santos via Guix-patches via writes: > * gnu/packages/emacs-xyz.scm (emacs-eglot-jl): New variable. Thanks. > +(define-public emacs-eglot-jl > + (package > + (name "emacs-eglot-jl") > + (version "2.3.0") > + (source > + (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/non-Jedi/eglot-jl.git") Nitpick: I think ".git" suffixes are usually removed. > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "144q4fj3am165vf1vx2ljlsmpn8vvvs1b95qi3rxlwqskkx0lig3")))) > + (build-system emacs-build-system) > + (propagated-inputs (list emacs-eglot)) > + (arguments > + '(#:include '("^[^/]+.el$" > + "^[^/]+.jl$" > + "^[^/]+.toml$"))) This is a bit verbose, and ignores %default-include variable. I suggest (using G-expressions just because we can) (arguments (list #:include #~(cons "\\.(jl|toml)$" %default-include))) > + (home-page "https://github.com/non-Jedi/eglot-jl") > + (synopsis "Julia support for eglot") Nitpick: Julia support for Eglot > + (description > + "This package adds support for @code{emacs-eglot} to the Julia language.") Nitpick: ... support for Eglot to the Julia language. > + (license:cc-by2.0))) I think there is a typo here. You mean (license license:cc-by2.0) However, it seems to licensed under CC0 terms. Could you send an updated patch? Regards, -- Nicolas Goaziou