Re: 03/03: build: Do not remake doc/guix.1.

Re: 03/03: build: Do not remake doc/guix.1.

[Mathieu Lirzin]

Hello Eric,

Eric Bavier <bavier@member.fsf.org> writes:

> bavier pushed a commit to branch master
> in repository guix.
>
> commit 97966e6d65bd3d450f12c7bb41af5f9eafd35a60
> Author: Eric Bavier <bavier@member.fsf.org>
> Date:   Wed Mar 16 12:53:55 2016 -0500
>
>     build: Do not remake doc/guix.1.
>     
>     * doc.am (doc/guix.1): Do not depend on $(sub_commands_mans) which will
>       always appear out-of-date.
> ---

Can you explain more extensively what was the issue?  I don't understand
why $(sub_commands_mans) always appeared out-of-date.

> diff --git a/doc.am b/doc.am
> index 127029c..a1eabad 100644
> --- a/doc.am
> +++ b/doc.am
> @@ -129,8 +129,12 @@ HELP2MANFLAGS = --source=GNU --info-page=$(PACKAGE_TARNAME)
>  
>  # Note: Do not depend on 'scripts/guix' since that would trigger a rebuild
>  # even for people building from a tarball.
> -doc/guix.1: $(sub_commands_mans)
> -	-$(AM_V_HELP2MAN)$(gen_man) --output="$@" `basename "$@" .1`
> +doc/guix.1: scripts/guix.in $(GOBJECTS)
> +	-@case '$?' in \
> +	  *$<*) $(AM_V_P) && set -x || echo "  HELP2MAN $@"; \
> +	        $(gen_man) --output="$@" "guix";; \
> +	  *)    : ;; \
> +	esac

Thanks.

-- 
Mathieu Lirzin

Re: 03/03: build: Do not remake doc/guix.1.

[Ludovic Courtès]

Mathieu Lirzin <mthl@gnu.org> skribis:

> Eric Bavier <bavier@member.fsf.org> writes:
>
>> bavier pushed a commit to branch master
>> in repository guix.
>>
>> commit 97966e6d65bd3d450f12c7bb41af5f9eafd35a60
>> Author: Eric Bavier <bavier@member.fsf.org>
>> Date:   Wed Mar 16 12:53:55 2016 -0500
>>
>>     build: Do not remake doc/guix.1.
>>     
>>     * doc.am (doc/guix.1): Do not depend on $(sub_commands_mans) which will
>>       always appear out-of-date.
>> ---
>
> Can you explain more extensively what was the issue?  I don't understand
> why $(sub_commands_mans) always appeared out-of-date.

The problem was that doc/guix.1 would always be remade, as could be
witnessed when running ‘make distcheck’.

Ludo’.