From: ludo@gnu.org (Ludovic Courtès)
To: mike rosset <mike.rosset@gmail.com>
Cc: 30159@debbugs.gnu.org
Subject: [bug#30159] [PATCH 1/2] gnu: Add deluge.
Date: Tue, 30 Jan 2018 22:09:00 +0100 [thread overview]
Message-ID: <87fu6nvytv.fsf@gnu.org> (raw)
In-Reply-To: <20180118175659.647c7d6f@scratchpost.org> (Danny Milosavljevic's message of "Thu, 18 Jan 2018 17:56:59 +0100")
Hello Mike,
Could you follow up Danny’s suggestions by sending updated patches?
Looks like you’re almost there. :-)
Thank you!
Ludo’.
Danny Milosavljevic <dannym@scratchpost.org> skribis:
> Hi,
>
> thanks for the patch.
>
> On Thu, 18 Jan 2018 07:03:50 -0800
> mike rosset <mike.rosset@gmail.com> wrote:
>
>> * gnu/packages/bittorrent.scm (deluge): New variable.
>> ---
>> gnu/packages/bittorrent.scm | 34 ++++++++++++++++++++++++++++++++++
>> 1 file changed, 34 insertions(+)
>>
>> diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
>> index 053988c8d..17c72a635 100644
>> --- a/gnu/packages/bittorrent.scm
>> +++ b/gnu/packages/bittorrent.scm
>> @@ -41,6 +41,7 @@
>> #:use-module (gnu packages cyrus-sasl)
>> #:use-module (gnu packages databases)
>> #:use-module (gnu packages file)
>> + #:use-module (gnu packages freedesktop)
>> #:use-module (gnu packages glib)
>> #:use-module (gnu packages gnome)
>> #:use-module (gnu packages gnupg)
>> @@ -53,6 +54,7 @@
>> #:use-module (gnu packages ncurses)
>> #:use-module (gnu packages pkg-config)
>> #:use-module (gnu packages python)
>> + #:use-module (gnu packages python-crypto)
>> #:use-module (gnu packages ssh)
>> #:use-module (gnu packages tls)
>> #:use-module (gnu packages xml))
>> @@ -408,3 +410,35 @@ desktops.")
>> (license l:bsd-2)))
>>
>>
>> +(define-public deluge
>
> The name suggests that this is a program and not a library (which is fine).
>
>> + (propagated-inputs
>> + `(("python2-pygtk" ,python2-pygtk)
>> + ("python2-chardet" ,python2-chardet)
>> + ("python2-pyopenssl" ,python2-pyopenssl)
>> + ("python2-libtorrent" ,python2-libtorrent)
>> + ("python2-twisted" ,python2-twisted)
>> + ("python2-pyxdg" ,python2-pyxdg)))
>
> Hmm, ok, but for programs, regular inputs would work as well.
>
>> +As Deluge heavily utilises the libtorrent library")
>
> ^^^^ Sentence is cut.
next prev parent reply other threads:[~2018-01-30 21:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 15:03 [bug#30159] [PATCH 1/2] gnu: Add deluge mike rosset
2018-01-18 15:03 ` [bug#30159] [PATCH 2/2] gnu: Add python2-libtorrent mike rosset
2018-01-18 19:13 ` Danny Milosavljevic
2018-01-18 16:56 ` [bug#30159] [PATCH 1/2] gnu: Add deluge Danny Milosavljevic
2018-01-30 21:09 ` Ludovic Courtès [this message]
2018-11-22 8:14 ` Nam Nguyen
2018-11-22 8:30 ` Nam Nguyen
2018-11-24 0:56 ` bug#30159: " Marius Bakke
2018-11-24 2:25 ` [bug#30159] " Nam Nguyen
2018-11-22 9:49 ` [bug#30159] [PATCH] " Nam Nguyen
2018-11-22 9:49 ` [bug#30159] [PATCH] gnu: Add libtorrent-rasterbar-c++11 Nam Nguyen
2018-11-22 9:49 ` [bug#30159] [PATCH] gnu: Add python-service-identity Nam Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fu6nvytv.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=30159@debbugs.gnu.org \
--cc=mike.rosset@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.