From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56421)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1egdBM-0005GJ-Oh
	for guix-patches@gnu.org; Tue, 30 Jan 2018 16:12:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1egdAI-0006aU-JG
	for guix-patches@gnu.org; Tue, 30 Jan 2018 16:11:08 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:41974)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1egdAI-0006Zz-8B
	for guix-patches@gnu.org; Tue, 30 Jan 2018 16:10:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1egdAI-0005rP-0y
	for guix-patches@gnu.org; Tue, 30 Jan 2018 16:10:02 -0500
Subject: [bug#30159] [PATCH 1/2] gnu: Add deluge.
Resent-Message-ID: <handler.30159.B30159.151734654422451@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180118150351.1671-1-mike.rosset@gmail.com>
	<20180118175659.647c7d6f@scratchpost.org>
Date: Tue, 30 Jan 2018 22:09:00 +0100
In-Reply-To: <20180118175659.647c7d6f@scratchpost.org> (Danny Milosavljevic's
	message of "Thu, 18 Jan 2018 17:56:59 +0100")
Message-ID: <87fu6nvytv.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: mike rosset <mike.rosset@gmail.com>
Cc: 30159@debbugs.gnu.org

Hello Mike,

Could you follow up Danny=E2=80=99s suggestions by sending updated patches?
Looks like you=E2=80=99re almost there.  :-)

Thank you!

Ludo=E2=80=99.

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> Hi,
>
> thanks for the patch.
>
> On Thu, 18 Jan 2018 07:03:50 -0800
> mike rosset <mike.rosset@gmail.com> wrote:
>
>> * gnu/packages/bittorrent.scm (deluge): New variable.
>> ---
>>  gnu/packages/bittorrent.scm | 34 ++++++++++++++++++++++++++++++++++
>>  1 file changed, 34 insertions(+)
>>=20
>> diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
>> index 053988c8d..17c72a635 100644
>> --- a/gnu/packages/bittorrent.scm
>> +++ b/gnu/packages/bittorrent.scm
>> @@ -41,6 +41,7 @@
>>    #:use-module (gnu packages cyrus-sasl)
>>    #:use-module (gnu packages databases)
>>    #:use-module (gnu packages file)
>> +  #:use-module (gnu packages freedesktop)
>>    #:use-module (gnu packages glib)
>>    #:use-module (gnu packages gnome)
>>    #:use-module (gnu packages gnupg)
>> @@ -53,6 +54,7 @@
>>    #:use-module (gnu packages ncurses)
>>    #:use-module (gnu packages pkg-config)
>>    #:use-module (gnu packages python)
>> +  #:use-module (gnu packages python-crypto)
>>    #:use-module (gnu packages ssh)
>>    #:use-module (gnu packages tls)
>>    #:use-module (gnu packages xml))
>> @@ -408,3 +410,35 @@ desktops.")
>>      (license l:bsd-2)))
>>=20=20
>>=20=20
>> +(define-public deluge
>
> The name suggests that this is a program and not a library (which is fine=
).
>
>> +    (propagated-inputs
>> +     `(("python2-pygtk" ,python2-pygtk)
>> +       ("python2-chardet" ,python2-chardet)
>> +       ("python2-pyopenssl" ,python2-pyopenssl)
>> +       ("python2-libtorrent" ,python2-libtorrent)
>> +       ("python2-twisted" ,python2-twisted)
>> +       ("python2-pyxdg" ,python2-pyxdg)))
>
> Hmm, ok, but for programs, regular inputs would work as well.
>
>> +As Deluge heavily utilises the libtorrent library")
>
> ^^^^ Sentence is cut.