all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Eric Bavier <ericbavier@centurylink.net>
Cc: guix-devel@gnu.org, Joshua Branson <jbranso@fastmail.com>,
	33572@debbugs.gnu.org
Subject: Re: [bug#33572] Guile-JSON now seems to be a required dependency
Date: Mon, 03 Dec 2018 09:46:40 +0100	[thread overview]
Message-ID: <87ftvfatfz.fsf@gnu.org> (raw)
In-Reply-To: <20181202163850.63cb6d9e@centurylink.net> (Eric Bavier's message of "Sun, 2 Dec 2018 16:38:50 -0600")

Hi,

Eric Bavier <ericbavier@centurylink.net> skribis:

> From 5f04eb187de528f5879bd84901f71dba13c68f43 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Sat, 1 Dec 2018 20:46:22 -0600
> Subject: [PATCH] Make Guile-JSON a required dependency.
>
> * README (Requirements): Remove "optional" verbiage.
> * doc/guix.texi (Requirements): Move Guile-JSON from optional to required.
> * configure.ac (HAVE_GUILE_JSON): Remove Automake conditional.
> (have_guile_json): Error if not "yes".
> * Makefile.am (MODULE, SCM_TESTS)[HAVE_GUILE_JSON]: Add modules and tests
> unconditionally.
> * gnu/packages/package-mangement.scm (guix-minimal)[propagated-inputs]: Leave
> guile-json input.

One last thing: guix.texi contains a few footnotes like:

  This functionality requires Guile-JSON to be installed.

Could you remove them as well?

Otherwise LGTM, thank you!

Ludo’.

WARNING: multiple messages have this Message-ID (diff)
From: ludo@gnu.org (Ludovic Courtès)
To: Eric Bavier <ericbavier@centurylink.net>
Cc: guix-devel@gnu.org, Joshua Branson <jbranso@fastmail.com>,
	33572@debbugs.gnu.org
Subject: [bug#33572] Guile-JSON now seems to be a required dependency
Date: Mon, 03 Dec 2018 09:46:40 +0100	[thread overview]
Message-ID: <87ftvfatfz.fsf@gnu.org> (raw)
In-Reply-To: <20181202163850.63cb6d9e@centurylink.net> (Eric Bavier's message of "Sun, 2 Dec 2018 16:38:50 -0600")

Hi,

Eric Bavier <ericbavier@centurylink.net> skribis:

> From 5f04eb187de528f5879bd84901f71dba13c68f43 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Sat, 1 Dec 2018 20:46:22 -0600
> Subject: [PATCH] Make Guile-JSON a required dependency.
>
> * README (Requirements): Remove "optional" verbiage.
> * doc/guix.texi (Requirements): Move Guile-JSON from optional to required.
> * configure.ac (HAVE_GUILE_JSON): Remove Automake conditional.
> (have_guile_json): Error if not "yes".
> * Makefile.am (MODULE, SCM_TESTS)[HAVE_GUILE_JSON]: Add modules and tests
> unconditionally.
> * gnu/packages/package-mangement.scm (guix-minimal)[propagated-inputs]: Leave
> guile-json input.

One last thing: guix.texi contains a few footnotes like:

  This functionality requires Guile-JSON to be installed.

Could you remove them as well?

Otherwise LGTM, thank you!

Ludo’.

  reply	other threads:[~2018-12-03  8:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-01  4:45 Guile-JSON now seems to be a required dependency Timothy Sample
2018-12-01 13:39 ` Joshua Branson
2018-12-01 15:16 ` Eric Bavier
2018-12-01 18:55   ` Timothy Sample
2018-12-02 18:58     ` Joshua Branson
2018-12-02 21:59       ` Ludovic Courtès
2018-12-02 22:22         ` Eric Bavier
2018-12-02 22:38           ` [bug#33572] " Eric Bavier
2018-12-03  8:46             ` Ludovic Courtès [this message]
2018-12-03  8:46               ` Ludovic Courtès
2018-12-03 14:58               ` Eric Bavier
2018-12-03 14:58                 ` Eric Bavier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftvfatfz.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=33572@debbugs.gnu.org \
    --cc=ericbavier@centurylink.net \
    --cc=guix-devel@gnu.org \
    --cc=jbranso@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.