From: "Ludovic Courtès" <ludo@gnu.org>
To: Ivan Petkov <ivanppetkov@gmail.com>
Cc: 35318@debbugs.gnu.org, Chris Marusich <cmmarusich@gmail.com>
Subject: [bug#35318] [PATCH] Update cargo-build-system to expand package inputs
Date: Mon, 06 May 2019 10:00:50 +0200 [thread overview]
Message-ID: <87ftpsnhal.fsf@gnu.org> (raw)
In-Reply-To: <E6292059-4F4A-4360-BF82-CB4674A997E5@gmail.com> (Ivan Petkov's message of "Thu, 18 Apr 2019 22:34:05 -0700")
Hello,
Ivan Petkov <ivanppetkov@gmail.com> skribis:
> From ca6dfd9451f22c4d6dc02aa7eceee0c35800dd57 Mon Sep 17 00:00:00 2001
> From: Ivan Petkov <ivanppetkov@gmail.com>
> Date: Tue, 16 Apr 2019 03:32:44 -0700
> Subject: [PATCH 1/4] packages: allow dynamic input closure computation
>
> * guix/packages: (transitive-inputs): Rename to
> package-transitive-dependencies.
> (package-transitive-dependencies): Add proc parameter and use it.
> (transitive-inputs): Add it.
There’s nothing written in terms of “dependencies”; instead everything
is written in terms of “inputs”, so I’d like to remain consistent here.
If we need something more specific, I’d rather see it as a private
procedure in (guix build-system cargo-build-system).
Danny wrote:
> It's used in patch 2 in order to consider both inputs and propagated inputs
> rather than just propagated inputs.
I’m not sure I want to know the details :-), but it seems to be what
‘package-transitive-inputs’ does, no?
(define (package-transitive-inputs package)
"Return the transitive inputs of PACKAGE---i.e., its direct inputs along
with their propagated inputs, recursively."
(transitive-inputs (package-direct-inputs package)))
Do you have an example of a package where this is not enough?
Thanks,
Ludo’.
next prev parent reply other threads:[~2019-05-06 8:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 5:34 [bug#35318] [PATCH] Update cargo-build-system to expand package inputs Ivan Petkov
2019-05-04 16:40 ` Ivan Petkov
2019-05-04 18:31 ` Danny Milosavljevic
2019-05-04 21:09 ` Ivan Petkov
2019-05-06 8:00 ` Ludovic Courtès [this message]
2019-05-06 16:04 ` Ivan Petkov
2019-05-09 23:17 ` Ivan Petkov
2019-05-15 6:08 ` Ivan Petkov
2019-05-15 12:44 ` Ludovic Courtès
2019-05-20 1:00 ` Ivan Petkov
2019-05-20 19:38 ` Ludovic Courtès
2019-05-22 2:48 ` Ivan Petkov
2019-06-08 18:44 ` Chris Marusich
2019-06-08 23:33 ` Ivan Petkov
2019-06-09 23:53 ` Ivan Petkov
2019-06-12 1:14 ` bug#35318: " Chris Marusich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftpsnhal.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=35318@debbugs.gnu.org \
--cc=cmmarusich@gmail.com \
--cc=ivanppetkov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.